Fix build for i386 #138
Merged
Fix build for i386 #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gretay-js
reviewed
Aug 4, 2021
|
|
||
| let num_occurrences_phantom t = | ||
| (t land 0xfffff_00000_00000) lsr 40 | ||
| (t land (0xfffff lsl 40)) lsr 40 |
There was a problem hiding this comment.
On 32-bit targets, 0xfffff lsl 40 is 0, so the result of the expression in this line is always 0, is that intended?
There was a problem hiding this comment.
Flambda 2 doesn't support 32-bit compilation, so it's ok. It just needs not to cause a compile-time error when the compiler itself is being built.
gretay-js
approved these changes
Aug 4, 2021
mshinwell
added a commit
that referenced
this pull request
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two problems:
Cextcall;