Skip to content

💡 Would have sense to have file content in real files instead of strings? #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oscard0m opened this issue Mar 7, 2021 · 2 comments · Fixed by #12
Closed

💡 Would have sense to have file content in real files instead of strings? #11

oscard0m opened this issue Mar 7, 2021 · 2 comments · Fixed by #12
Labels
feature New feature or request released

Comments

@oscard0m
Copy link
Member

oscard0m commented Mar 7, 2021

An idea came to my mind from this PR: https://github.com/octoherd/create-octoherd-script/pull/10/files

What if we have had this GitHub workflow as a file and checked periodically by renovate? An automatic PR would have updated it for us (and for future releases of actions we decide to us in workflows).

Checking other files we scaffold with https://github.com/octoherd/create-octoherd-script maybe some checks and logic could be applied:

  • Prettier / Lint
  • Unit tests / transpilation / compilation...
  • Easier to manipulate with octoherd actions (modify its content in a programmatic way maybe?)
  • It would open the door of scaffolding a package.json and package.lock with controlled version of packages (controlled by renovate) instead of doing an npm i (not sure if this is valuable or it complicates more the ecosystem)

What's your opinion here @gr2m

@oscard0m oscard0m added the feature New feature or request label Mar 7, 2021
@gr2m
Copy link
Member

gr2m commented Mar 7, 2021

What if we have had this GitHub workflow as a file and checked periodically by renovate? An automatic PR would have updated it for us (and for future releases of actions we decide to us in workflows).

That's a good idea, I think we can do that.

Checking other files we scaffold with https://github.com/octoherd/create-octoherd-script maybe some checks and logic could be applied:

I don't want to force too much setup on people, they have their own preferences. Right now I think we should should probably sit back and see what people using it say about it

@github-actions
Copy link

github-actions bot commented Mar 7, 2021

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants