Skip to content

💡 To add // @ts-check #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oscard0m opened this issue Mar 7, 2021 · 5 comments · Fixed by #14 or #17
Closed

💡 To add // @ts-check #13

oscard0m opened this issue Mar 7, 2021 · 5 comments · Fixed by #14 or #17
Labels
maintenance Tests, Refactorings, Automation, etc released

Comments

@oscard0m
Copy link
Member

oscard0m commented Mar 7, 2021

Working in local was not giving to me JS errors by default. I was missing checkJS setting in my VSCode. After enabling it, I got this error:

image

this jsconfig.json fixed the error for me:

{
    "compilerOptions": {
        "checkJs": true,
        "module": "es2020",
        "target": "es2020",
    }
}
@oscard0m oscard0m added the maintenance Tests, Refactorings, Automation, etc label Mar 7, 2021
@oscard0m oscard0m mentioned this issue Mar 7, 2021
Merged
@gr2m
Copy link
Member

gr2m commented Mar 7, 2021 •
edited
Loading

can we just add a // @ts-check to the script.js file for now? Will it have the same effect?

@oscard0m
Copy link
Member Author

oscard0m commented Mar 7, 2021

can we just add a // @ts-check to the script.js file for now? Will it have the same effect?

Let me give it a try

@oscard0m oscard0m changed the title 💡 To add jsconfig.json 💡 To add //ts-check Mar 7, 2021
@oscard0m
Copy link
Member Author

oscard0m commented Mar 7, 2021

Modified title. I would go for the //ts-check solution

@gr2m gr2m changed the title 💡 To add //ts-check 💡 To add // @ts-check Mar 7, 2021
@oscard0m oscard0m mentioned this issue Mar 7, 2021
Merged
@github-actions
Copy link

github-actions bot commented Mar 7, 2021

🎉 This issue has been resolved in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This issue has been resolved in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Tests, Refactorings, Automation, etc released
Projects
None yet
Milestone
No milestone
2 participants
@gr2m @oscard0m