Should we run tsc --checkJs as a checkRun on CI?

[oscard0m]

Originally posted by @gr2m in #15 (comment)

[oscard0m]

To as a developer would be a valuable check but maybe it can be tedious for developers not wondering to deal with types. Maybe we can make it as a non-required check? Or... a non-required check is confusing for end-users? @gr2m

[gr2m]

I'm not sure either, I didn't try this before myself.

I just tried to run

npx -p typescript tsc --checkJs

but I get an error, as if the --checkJs no longer exists? Do you know anything about that? How do you run tsc with the checkRun flag locally? What TypeScript version are you using?

[oscard0m]

With tsc the command is --allowJs

This is the command I run to make it work in script-setup-renovate-setup:

npx -p typescript tsc --allowJs --noEmit --lib es2020 *.js

[gr2m]

looks good 👍🏼 I'd say let's add this check to our CI tests, maybe also add them to the scripts we create using npm init octoherd-script. We can remove it or make it optional once people complain. I think it's a good thing to have. What do you think?

[oscard0m]

looks good 👍🏼 I'd say let's add this check to our CI tests, maybe also add them to the scripts we create using npm init octoherd-script. We can remove it or make it optional once people complain. I think it's a good thing to have. What do you think?

To me it’s very useful to have this feedback at PR stage.

I think we would give more confidence to new contributors too.

[github-actions]

🎉 This issue has been resolved in version 1.4.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀