Skip to content

if script option is boolean, mentiond both "--option-name" and "--no-option-name" in options table #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gr2m opened this issue Mar 14, 2021 · 2 comments · Fixed by #21
Closed

if script option is boolean, mentiond both "--option-name" and "--no-option-name" in options table #20

gr2m opened this issue Mar 14, 2021 · 2 comments · Fixed by #21
Labels
released

Comments

@gr2m
Copy link
Member

gr2m commented Mar 14, 2021

follow up to octoherd/octoherd#18 (comment)

So instead of

option type description
--squash-merge boolean toggle squash merge
--merge-commit boolean toggle merge commit
--rebase-merge boolean toggle rebase merge

the script would create

option type description
--squash-merge or --no-squash-merge boolean toggle squash merge
--merge-commit or --no-merge-commit boolean toggle merge commit
--rebase-merge or --no-rebase-merge boolean toggle rebase merge

would that work for you @MunifTanjim?
@MunifTanjim
Copy link

I didn't think of documenting it this way. This would be great! 😃

@gr2m gr2m mentioned this issue Mar 14, 2021
Merged
@gr2m gr2m closed this as completed in #21 Mar 14, 2021
@github-actions
Copy link

🎉 This issue has been resolved in version 1.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improve documentation for boolean script arguments octoherd/create-octoherd-script
2 participants
@gr2m @MunifTanjim