Skip to content

Clarify "email for Code of Conduct" question #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gr2m opened this issue Apr 19, 2021 · 4 comments · Fixed by #35
Closed

Clarify "email for Code of Conduct" question #28

gr2m opened this issue Apr 19, 2021 · 4 comments · Fixed by #35
Labels
feature New feature or request first-timers-only Reserved for first-time contributors good first issue Good for contributors new to octoherd pull request welcome Ready to work on released

Comments

@gr2m
Copy link
Member

gr2m commented Apr 19, 2021 •
edited
Loading

I've seen @bdougie being confused by this question during his stream on Friday:
https://www.twitch.tv/videos/989570564

We should clarify that the email is for the CODE_OF_CONDUCT.md file of the newly created repository, and not something @octoherd asks to get from its users for some reason

The change needs to happen in lib/prompts.js.
@gr2m gr2m added feature New feature or request good first issue Good for contributors new to octoherd pull request welcome Ready to work on labels Apr 19, 2021
@gr2m
Copy link
Member Author

gr2m commented Apr 19, 2021

instead of the current question:

? Email for Code of Conduct

We could do

? Email for the repository's CODE_OF_CONDUCT.md file

Would that make it clear? @bdougie

@bdougie
Copy link

bdougie commented Apr 19, 2021

Yeah, that would be helpful. It is much more specific that its is for the soon-to-be-generated file. Though, It might be more clear as:

What email can folks reach out to for Code of Conduct inquiries?

@gr2m
Copy link
Member Author

gr2m commented Apr 19, 2021

What email can folks reach out to for Code of Conduct inquiries?

love it, let's use that, thank you!

@gr2m gr2m added the first-timers-only Reserved for first-time contributors label Apr 19, 2021
@gr2m gr2m mentioned this issue May 4, 2021
Merged
@gr2m gr2m closed this as completed in #35 May 4, 2021
@github-actions
Copy link

github-actions bot commented May 4, 2021

🎉 This issue has been resolved in version 1.3.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request first-timers-only Reserved for first-time contributors good first issue Good for contributors new to octoherd pull request welcome Ready to work on released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: updated email prompt VincenteAvalos/create-octoherd-script
2 participants
@gr2m @bdougie