-
Notifications
You must be signed in to change notification settings - Fork 0
Comparing changes
Open a pull request
base repository: mmito/openfeature-php-sdk
base: main
head repository: open-feature/php-sdk
compare: main
- 12 commits
- 14 files changed
- 7 contributors
Commits on Oct 28, 2024
-
fix: correct merging of contexts with targetingKey (open-feature#136)
<!-- Please use this template for your pull request. --> <!-- Please use the sections that you need and delete other sections --> ## This PR <!-- add the description of the PR here --> Corrects the behavior of EvaluationContextMerger `merge()` when using string `targetingKey`. ### Related Issues <!-- add here the GitHub issue that this PR resolves if applicable --> Fixes open-feature#135 ### Notes <!-- any additional notes for this PR --> ### Follow-up Tasks <!-- anything that is related to this PR but not done here should be noted under this section --> <!-- if there is a need for a new issue, please link it here --> ### How to test <!-- if applicable, add testing instructions under this section --> The `testEvaluationContextMergingTargetingKey` test in EvaluationContextTest.php has been added. The test fails without the proposed fix, as expected. Signed-off-by: Tommaso Tofacchi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3f141d7 - Browse repository at this point
Copy the full SHA 3f141d7View commit details -
chore(main): release 2.0.10 (open-feature#137)
🤖 I have created a release *beep* *boop* --- ## [2.0.10](open-feature/php-sdk@2.0.9...2.0.10) (2024-10-28) ### 🐛 Bug Fixes * correct merging of contexts with targetingKey ([open-feature#136](open-feature#136)) ([3f141d7](open-feature@3f141d7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for c71bf42 - Browse repository at this point
Copy the full SHA c71bf42View commit details
Commits on Jul 9, 2025
-
chore: reduce unnecessary package exports (open-feature#148)
## This PR Fix broken symlink artefact. Updates package exports to reduce clutter. ### Notes Prompted by a broken deployment, which was trying to chown files in an entrypoint and falling over with `.pre-commit-config.yaml` (which links to a non-existent file), causing the container to crash. It may be easier to read the PR by disabling the whitespace in the diff, as I had to realign the existing spacing. ### How to test Checkout this branch, then `git archive HEAD | tar tf -`. You should receive the following: ```text LICENSE README.md composer.json src/ src/OpenFeatureAPI.php src/OpenFeatureClient.php src/implementation/ src/implementation/.gitkeep src/implementation/common/ src/implementation/common/ArrayHelper.php src/implementation/common/Metadata.php src/implementation/common/StringHelper.php src/implementation/common/ValueTypeValidator.php src/implementation/errors/ src/implementation/errors/FlagValueTypeError.php src/implementation/errors/InvalidResolutionValueError.php src/implementation/flags/ src/implementation/flags/Attributes.php src/implementation/flags/AttributesMerger.php src/implementation/flags/EvaluationContext.php src/implementation/flags/EvaluationContextMerger.php src/implementation/flags/EvaluationDetails.php src/implementation/flags/EvaluationDetailsBuilder.php src/implementation/flags/EvaluationDetailsFactory.php src/implementation/flags/EvaluationOptions.php src/implementation/flags/MutableAttributes.php src/implementation/flags/MutableEvaluationContext.php src/implementation/flags/NoOpClient.php src/implementation/hooks/ src/implementation/hooks/AbstractHook.php src/implementation/hooks/AbstractHookContext.php src/implementation/hooks/BooleanHook.php src/implementation/hooks/FloatHook.php src/implementation/hooks/HookContextBuilder.php src/implementation/hooks/HookContextFactory.php src/implementation/hooks/HookContextTransformer.php src/implementation/hooks/HookExecutor.php src/implementation/hooks/HookHints.php src/implementation/hooks/ImmutableHookContext.php src/implementation/hooks/IntegerHook.php src/implementation/hooks/MutableHookContext.php src/implementation/hooks/ObjectHook.php src/implementation/hooks/StringHook.php src/implementation/provider/ src/implementation/provider/AbstractProvider.php src/implementation/provider/NoOpProvider.php src/implementation/provider/Reason.php src/implementation/provider/ResolutionDetails.php src/implementation/provider/ResolutionDetailsBuilder.php src/implementation/provider/ResolutionDetailsFactory.php src/implementation/provider/ResolutionError.php src/interfaces/ src/interfaces/common/ src/interfaces/common/LoggerAwareTrait.php src/interfaces/common/Metadata.php src/interfaces/common/MetadataGetter.php src/interfaces/common/StringIndexed.php src/interfaces/common/TypeValuePair.php src/interfaces/flags/ src/interfaces/flags/API.php src/interfaces/flags/AttributeByTypeExporter.php src/interfaces/flags/AttributeType.php src/interfaces/flags/Attributes.php src/interfaces/flags/Client.php src/interfaces/flags/EvaluationContext.php src/interfaces/flags/EvaluationContextAware.php src/interfaces/flags/EvaluationDetails.php src/interfaces/flags/EvaluationOptions.php src/interfaces/flags/FeatureDetails.php src/interfaces/flags/FeatureValues.php src/interfaces/flags/FlagValueType.php src/interfaces/flags/MutableAttributes.php src/interfaces/flags/MutableEvaluationContext.php src/interfaces/hooks/ src/interfaces/hooks/Hook.php src/interfaces/hooks/HookContext.php src/interfaces/hooks/HookHints.php src/interfaces/hooks/HooksAdder.php src/interfaces/hooks/HooksAware.php src/interfaces/hooks/HooksAwareTrait.php src/interfaces/hooks/HooksGetter.php src/interfaces/hooks/HooksSetter.php src/interfaces/hooks/MutableHookContext.php src/interfaces/provider/ src/interfaces/provider/ErrorCode.php src/interfaces/provider/Provider.php src/interfaces/provider/ProviderAware.php src/interfaces/provider/Reason.php src/interfaces/provider/ResolutionDetails.php src/interfaces/provider/ResolutionError.php src/interfaces/provider/ThrowableWithResolutionError.php ``` Signed-off-by: Chris Lightfoot-Wild <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 845d9d8 - Browse repository at this point
Copy the full SHA 845d9d8View commit details -
fix(deps): update dependency open-feature/flagd-provider to v1 (open-…
…feature#130) This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [open-feature/flagd-provider](https://redirect.github.com/open-feature-php/flagd-provider) | `^0.7.0` -> `^1.0.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>open-feature-php/flagd-provider (open-feature/flagd-provider)</summary> ### [`v1.0.0`](https://redirect.github.com/open-feature-php/flagd-provider/compare/0.8.0...1.0.0) [Compare Source](https://redirect.github.com/open-feature-php/flagd-provider/compare/0.8.0...1.0.0) ### [`v0.8.0`](https://redirect.github.com/open-feature-php/flagd-provider/compare/0.7.0...0.8.0) [Compare Source](https://redirect.github.com/open-feature-php/flagd-provider/compare/0.7.0...0.8.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-feature/php-sdk). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiNDEuMTcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 398820c - Browse repository at this point
Copy the full SHA 398820cView commit details -
chore(main): release 2.0.11 (open-feature#149)
🤖 I have created a release *beep* *boop* --- ## [2.0.11](open-feature/php-sdk@2.0.10...2.0.11) (2025-07-09) ### 🐛 Bug Fixes * **deps:** update dependency open-feature/flagd-provider to v1 ([open-feature#130](open-feature#130)) ([398820c](open-feature@398820c)) ### 🧹 Chore * reduce unnecessary package exports ([open-feature#148](open-feature#148)) ([845d9d8](open-feature@845d9d8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for e8622b3 - Browse repository at this point
Copy the full SHA e8622b3View commit details
Commits on Aug 29, 2025
-
test: Write test case for scenario where invalid flag type is provide…
…d to be resolved in the client (open-feature#153) ### Test This PR adds a test case to ensure that an error is thrown when an invalid flag type is provided for resolution in the client. While this scenario is not expected to occur in practice, the test improves coverage by verifying that the client behaves correctly and returns the expected error when such an edge case is encountered. ### Checklist - [x] Test that an error is returned when an invalid flag type is resolved - [x] Test that the error message matches the FlagValueTypeError template message ### Proof that test cases passed ``` tolumakinde@tolus-MacBook-Pro php-sdk % vendor/phpunit/phpunit/phpunit PHPUnit 9.6.25 by Sebastian Bergmann and contributors. Runtime: PHP 8.3.20 Configuration: /Users/tolumakinde/demo-projects/php-sdk/phpunit.xml.dist ............................................................... 63 / 149 ( 42%) ............................................................... 126 / 149 ( 84%) ....................... 149 / 149 (100%) Time: 00:00.058, Memory: 10.00 MB OK (149 tests, 319 assertions) ``` Signed-off-by: tmakinde <[email protected]> Co-authored-by: tmakinde <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c3686b7 - Browse repository at this point
Copy the full SHA c3686b7View commit details -
chore(deps): update actions/checkout action to v5 (open-feature#151)
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/checkout](https://redirect.github.com/actions/checkout) | action | major | `v4` -> `v5` | --- ### Release Notes <details> <summary>actions/checkout (actions/checkout)</summary> ### [`v5`](https://redirect.github.com/actions/checkout/compare/v4...v5) [Compare Source](https://redirect.github.com/actions/checkout/compare/v4...v5) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-feature/php-sdk). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS42MC40IiwidXBkYXRlZEluVmVyIjoiNDEuNjAuNCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for fa48aca - Browse repository at this point
Copy the full SHA fa48acaView commit details -
chore(deps): update amannn/action-semantic-pull-request action to v6 (o…
…pen-feature#152) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [amannn/action-semantic-pull-request](https://redirect.github.com/amannn/action-semantic-pull-request) | action | major | `v5` -> `v6` | --- ### Release Notes <details> <summary>amannn/action-semantic-pull-request (amannn/action-semantic-pull-request)</summary> ### [`v6`](https://redirect.github.com/amannn/action-semantic-pull-request/compare/v5...v6) [Compare Source](https://redirect.github.com/amannn/action-semantic-pull-request/compare/v5...v6) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-feature/php-sdk). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS42Ni4yIiwidXBkYXRlZEluVmVyIjoiNDEuNjYuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 7f0e277 - Browse repository at this point
Copy the full SHA 7f0e277View commit details
Commits on Sep 4, 2025
-
chore(main): release 2.0.12 (open-feature#155)
🤖 I have created a release *beep* *boop* --- ## [2.0.12](open-feature/php-sdk@2.0.11...2.0.12) (2025-08-29) ### 🧹 Chore * **deps:** update actions/checkout action to v5 ([open-feature#151](open-feature#151)) ([fa48aca](open-feature@fa48aca)) * **deps:** update amannn/action-semantic-pull-request action to v6 ([open-feature#152](open-feature#152)) ([7f0e277](open-feature@7f0e277)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 17e0510 - Browse repository at this point
Copy the full SHA 17e0510View commit details
Commits on Sep 10, 2025
-
test: Write test for OpenfeatureAPI to return No-op client when Openf…
…eatureClient is unresolvable (open-feature#157) ### Overview This pull request refactors the client creation logic in `OpenFeatureAPI` to improve testability and resilience. - Introduces a dedicated `resolveClient` method, which encapsulates client instantiation logic. - Ensures that failures during client resolution are handled gracefully by returning a `NoOpClient`. - Adds a testing dependency to allow mocking of final classes, enabling comprehensive test coverage without altering production code. --------- Signed-off-by: tmakinde <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2c4dba8 - Browse repository at this point
Copy the full SHA 2c4dba8View commit details
Commits on Sep 14, 2025
-
feat(log): Improve error log in OpenFeatureClient (open-feature#156)
Change log message to follow best practice of PSR3, Log Exception object to help debuging, when provider throw Exception <!-- Please use this template for your pull request. --> <!-- Please use the sections that you need and delete other sections --> ## This PR <!-- add the description of the PR here --> - Improve the log message and context, when the OpenFeatureClient catch Exception ### Related Issues <!-- add here the GitHub issue that this PR resolves if applicable --> ### Notes <!-- any additional notes for this PR --> ### Follow-up Tasks <!-- anything that is related to this PR but not done here should be noted under this section --> <!-- if there is a need for a new issue, please link it here --> ### How to test <!-- if applicable, add testing instructions under this section --> - Unit test updated to test the changes --------- Signed-off-by: jaugustin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d28d9c3 - Browse repository at this point
Copy the full SHA d28d9c3View commit details
Commits on Sep 27, 2025
-
chore(main): release 2.1.0 (open-feature#158)
🤖 I have created a release *beep* *boop* --- ## [2.1.0](open-feature/php-sdk@2.0.12...2.1.0) (2025-09-14) ### ✨ New Features * **log:** Improve error log in OpenFeatureClient ([open-feature#156](open-feature#156)) ([d28d9c3](open-feature@d28d9c3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for af1de42 - Browse repository at this point
Copy the full SHA af1de42View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...main