[Fix] Fix module PascalContextDataset #3235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiexinch
reviewed
Aug 1, 2023
mmseg/datasets/pascal_context.py
Outdated
| ann_file='', | ||
| img_suffix='.jpg', | ||
| seg_map_suffix='.png', | ||
| reduce_zero_label=True, |
Collaborator
There was a problem hiding this comment.
We can't set reduce_zero_label to True here.
https://mmsegmentation.readthedocs.io/en/latest/notes/faq.html#functionality-of-reduce-zero-label
mmseg/datasets/pascal_context.py
Outdated
| img_suffix='.jpg', | ||
| seg_map_suffix='.png', | ||
| reduce_zero_label=True, | ||
| reduce_zero_label=False, |
Collaborator
There was a problem hiding this comment.
And here it should be True.
Contributor
Author
There was a problem hiding this comment.
Thank you for your correction. I think I was confused because when I created the annotation maps, I had set the background to 255, and the category labels are 0-59, which caused me to set recude_zero_label to False in class ''PascalContextDataset59''. I've restored the settings for reduce_zero_label.
xiexinch
approved these changes
Aug 2, 2023
angiecao
added a commit
to angiecao/mmsegmentation
that referenced
this pull request
Aug 31, 2023
## Motivation - 'PascalContextDataset' object has no attribute 'file_client', it will cause an error. - The attribute ‘ann_file’ is not allowed to be empty, otherwise, an error will be reported. ## Modification - Replace file_client with fileio
emily-lin
pushed a commit
to emily-lin/mmsegmentation
that referenced
this pull request
Nov 18, 2023
## Motivation - 'PascalContextDataset' object has no attribute 'file_client', it will cause an error. - The attribute ‘ann_file’ is not allowed to be empty, otherwise, an error will be reported. ## Modification - Replace file_client with fileio
nahidnazifi87
pushed a commit
to nahidnazifi87/mmsegmentation_playground
that referenced
this pull request
Apr 5, 2024
## Motivation - 'PascalContextDataset' object has no attribute 'file_client', it will cause an error. - The attribute ‘ann_file’ is not allowed to be empty, otherwise, an error will be reported. ## Modification - Replace file_client with fileio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modification