Skip to content

Generate YAML with "openfaas" release name #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexellis opened this issue Apr 24, 2020 · 0 comments
Closed

Generate YAML with "openfaas" release name #622

alexellis opened this issue Apr 24, 2020 · 0 comments

Comments

@alexellis
Copy link
Member

Expected Behaviour

The arkade app installs openfaas with a release name of openfaas, and the chart's static YAML should do the same.

Current Behaviour

It generates as faas

Possible Solution

Update this line in create-static-manifest.sh

helm template "$CHART_DIR" --name=faas --namespace="$NAMEPSPACE" --set "functionNamespace=$FUNCTIONNAMESPACE" -x templates/$filename --values="$VALUESNAME" \

Context

This is useful for testing helm patches when openfaas is already installed on a cluster - such as changing RBAC rules.

It will be a breaking change and users will not be able to upgrade if they use the plain YAML. We strongly recommend not to use plain YAML in the docs, so it should not be a problem if we make this change.

https://docs.openfaas.com/deployment/kubernetes/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant