Skip to content

Commit 3120454

Browse files
committed
Fix the pep8 error on Noble
pep8 job failing on Noble with below error. Bumping the hacking version to 7.0.0 to fix it - AttributeError: 'EntryPoints' object has no attribute 'get' Closes-Bug: #2088356 Change-Id: Ib168ad6842dfcf5cac8a85db973e339d2225b444
1 parent 7e30ba3 commit 3120454

File tree

4 files changed

+14
-13
lines changed

4 files changed

+14
-13
lines changed

cinderclient/tests/unit/v3/fakes.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -401,16 +401,16 @@ def post_group_types_1_group_specs(self, body, **kw):
401401
return (200, {}, {'group_specs': {'k': 'v'}})
402402

403403
def delete_group_types_1_group_specs_k(self, **kw):
404-
return(204, {}, None)
404+
return (204, {}, None)
405405

406406
def delete_group_types_1_group_specs_m(self, **kw):
407-
return(204, {}, None)
407+
return (204, {}, None)
408408

409409
def delete_group_types_1(self, **kw):
410410
return (202, {}, None)
411411

412412
def delete_group_types_3_group_specs_k(self, **kw):
413-
return(204, {}, None)
413+
return (204, {}, None)
414414

415415
def delete_group_types_3(self, **kw):
416416
return (202, {}, None)

cinderclient/tests/unit/v3/fakes_base.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -772,16 +772,16 @@ def post_types_1_extra_specs(self, body, **kw):
772772
return (200, {}, {'extra_specs': {'k': 'v'}})
773773

774774
def delete_types_1_extra_specs_k(self, **kw):
775-
return(204, {}, None)
775+
return (204, {}, None)
776776

777777
def delete_types_1_extra_specs_m(self, **kw):
778-
return(204, {}, None)
778+
return (204, {}, None)
779779

780780
def delete_types_1(self, **kw):
781781
return (202, {}, None)
782782

783783
def delete_types_3_extra_specs_k(self, **kw):
784-
return(204, {}, None)
784+
return (204, {}, None)
785785

786786
def delete_types_3(self, **kw):
787787
return (202, {}, None)
@@ -936,13 +936,13 @@ def post_backups_1234_restore(self, **kw):
936936
{'restore': _stub_restore()})
937937

938938
def post_backups_76a17945_3c6f_435c_975b_b5685db10b62_action(self, **kw):
939-
return(200, {}, None)
939+
return (200, {}, None)
940940

941941
def post_backups_1234_action(self, **kw):
942-
return(200, {}, None)
942+
return (200, {}, None)
943943

944944
def post_backups_5678_action(self, **kw):
945-
return(200, {}, None)
945+
return (200, {}, None)
946946

947947
def get_backups_76a17945_3c6f_435c_975b_b5685db10b62_export_record(self,
948948
**kw):

cinderclient/v3/volumes_base.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ def update(self, **kwargs):
3333
return self.manager.update(self, **kwargs)
3434

3535
def attach(self, instance_uuid, mountpoint, mode='rw', host_name=None):
36-
"""Inform Cinder that the given volume is attached to the given instance.
36+
"""Inform Cinder if the given volume is attached to the given instance.
3737
3838
Calling this method will not actually ask Cinder to attach
3939
a volume, but to mark it on the DB as attached. If the volume
@@ -54,9 +54,10 @@ def attach(self, instance_uuid, mountpoint, mode='rw', host_name=None):
5454
host_name)
5555

5656
def detach(self):
57-
"""Inform Cinder that the given volume is detached from the given instance.
57+
"""Inform Cinder that the given volume is detached.
5858
59-
Calling this method will not actually ask Cinder to detach
59+
This inform Cinder that the given volume is detached from the given
60+
instance. Calling this method will not actually ask Cinder to detach
6061
a volume, but to mark it on the DB as detached. If the volume
6162
is not actually detached from the given instance, inconsistent
6263
data will result.

test-requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# process, which may cause wedges in the gate later.
44
# Hacking already pins down pep8, pyflakes and flake8
55

6-
hacking>=4.0.0,<4.1.0 # Apache-2.0
6+
hacking>=7.0.0,<7.1.0 # Apache-2.0
77
flake8-import-order # LGPLv3
88
docutils>=0.16
99
coverage>=5.5 # Apache-2.0

0 commit comments

Comments
 (0)