Skip to content

Advantage/Disadvantage list formatting issues #3337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aaronaxvig opened this issue Feb 4, 2025 · 5 comments
Closed

Advantage/Disadvantage list formatting issues #3337

aaronaxvig opened this issue Feb 4, 2025 · 5 comments

Comments

@aaronaxvig
Copy link

On this page the Advantage/Disadvantage sections (two of them) have some formatting issues.

"Advantages Easy to add to an existing web server." should be on two lines, at a minimum. Probably both advantages should be bullet points.

Same for "Disadvantages ModSecurity can only protect the local web server."

And then in the section below there is a second pair of Advantages/Disadvantages that has the same formatting issue.

@airween
Copy link
Member

airween commented Feb 4, 2025

Hi @aaronaxvig,

thanks for letting us know this.

As I know, anyone can clone GH Wiki pages and can send PR's against them - could you take a look at this? And could we try that you send a PR to fix this issue?

Thanks!

@aaronaxvig
Copy link
Author

AFAICT one cannot create pull requests for wiki repos. I have forked the ModSecurity wiki repo and made some changes but there is no apparent way to compare it (and pull request) to the ModSecurity wiki repo. But my changes could be easily copied and pasted from my edited version. (raw version)

@aaronaxvig
Copy link
Author

Most concise evidence of pull requests for wikis not being a feature here.

@airween
Copy link
Member

airween commented Feb 4, 2025

Most concise evidence of pull requests for wikis not being a feature here.

Ah, I see - anyway, thanks for your help, I'll check your modifications and will apply in Wiki.

Thanks!

@airween
Copy link
Member

airween commented Feb 12, 2025

@aaronaxvig, I've picked up your modifications, many-many thanks for your help.

I saw you made other changes than the listing - thanks for everything.

I'm closing this issue.

@airween airween closed this as completed Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants