Skip to content

Commit 73263a4

Browse files
committed
of course I didn't push to main without running the tests, why do you ask
1 parent ea108b7 commit 73263a4

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

test/e2e/networking.e2e.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,12 @@ test('Create and edit subnet', async ({ page }) => {
5757
// VPC detail, subnets tab
5858
await expectVisible(page, [
5959
'role=heading[name*="mock-vpc"]',
60-
'role=tab[name="Subnets"]',
61-
// 'role=tab[name="System Routes"]',
62-
// 'role=tab[name="Routers"]',
6360
'role=tab[name="Firewall Rules"]',
64-
'role=cell[name="mock-subnet"]',
65-
// TODO: assert minitable contents
61+
'role=cell[name="allow-icmp"]',
6662
])
6763

64+
await page.getByRole('tab', { name: 'Subnets' }).click()
65+
6866
// Create subnet
6967
await page.click('role=button[name="New subnet"]')
7068
await expectVisible(page, [

test/e2e/vpcs.e2e.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,17 @@ import { expect, test } from '@playwright/test'
99

1010
test('can nav to VpcPage from /', async ({ page }) => {
1111
await page.goto('/')
12-
await page.click('table :text("mock-project")')
13-
await page.click('a:has-text("VPCs")')
14-
await page.click('a:has-text("mock-vpc")')
15-
await expect(page.locator('text=mock-subnet')).toBeVisible()
12+
await page.getByRole('table').getByRole('link', { name: 'mock-project' }).click()
13+
await page.getByRole('link', { name: 'VPCs' }).click()
14+
await page.getByRole('link', { name: 'mock-vpc' }).click()
15+
await expect(page.getByRole('tab', { name: 'Firewall rules' })).toBeVisible()
16+
await expect(page.getByRole('cell', { name: 'allow-icmp' })).toBeVisible()
1617
expect(await page.title()).toEqual('mock-vpc / VPCs / mock-project / Oxide Console')
1718
})
1819

1920
test('can create and delete subnet', async ({ page }) => {
2021
await page.goto('/projects/mock-project/vpcs/mock-vpc')
22+
await page.getByRole('tab', { name: 'Subnets' }).click()
2123
// only one row in table, the default mock-subnet
2224
const rows = page.locator('tbody >> tr')
2325
await expect(rows).toHaveCount(1)

0 commit comments

Comments
 (0)