Skip to content

Commit aaf1154

Browse files
committed
add extra assert for instance create with additional disks test flake
1 parent 79d610d commit aaf1154

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

test/e2e/instance-create.e2e.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -544,10 +544,17 @@ test('create instance with additional disks', async ({ page }) => {
544544
await page.getByRole('button', { name: 'Create new disk' }).click()
545545

546546
const createForm = page.getByRole('dialog', { name: 'Create disk' })
547+
await expect(createForm).toBeVisible() // kill time to help size field flake?
547548

548549
// verify that an existing name can't be used
549550
await createForm.getByRole('textbox', { name: 'Name', exact: true }).fill('disk-6')
550-
await createForm.getByRole('textbox', { name: 'Size (GiB)' }).fill('5')
551+
552+
// this fill fails to happen sometimes, causing test flakes. the assert here
553+
// should catch it slightly sooner
554+
const sizeField = createForm.getByRole('textbox', { name: 'Size (GiB)' })
555+
await sizeField.fill('5')
556+
await expect(sizeField).toHaveValue('5')
557+
551558
await createForm.getByRole('button', { name: 'Create disk' }).click()
552559
await expect(createForm.getByText('Name is already in use')).toBeVisible()
553560

0 commit comments

Comments
 (0)