Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: oxidecomputer/console
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 156c082c
Choose a base ref
...
head repository: oxidecomputer/console
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b22ca1dc
Choose a head ref
  • 13 commits
  • 63 files changed
  • 5 contributors

Commits on Mar 29, 2024

  1. Configuration menu
    Copy the full SHA
    9485ca2 View commit details
    Browse the repository at this point in the history
  2. Convert more tables to useQueryTable2 (#2111)

    * convert silo IP pools tab to useQueryTable2
    
    * set defaultCell inside QueryTable
    
    * we don't even need defaultCell. default cell color in table.css is already text-secondary
    
    * Convert FloatingIps page
    
    * comment on makeLinkCell about static or memoize
    
    * tweak floating IP instance name logic in detach modal
    
    * rename value prop of InstanceLinkCell to instanceId
    
    ---------
    
    Co-authored-by: Charlie Park <[email protected]>
    david-crespo and charliepark authored Mar 29, 2024
    Configuration menu
    Copy the full SHA
    4db8d83 View commit details
    Browse the repository at this point in the history
  3. Wrap all the makeActions functions in useCallback (#2112)

    wrap all the makeActions functions in useCallback
    david-crespo authored Mar 29, 2024
    Configuration menu
    Copy the full SHA
    1954709 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2024

  1. Reduce e2e flake (#2113)

    * try waiting for tab query param to show up
    
    * retain more traces
    david-crespo authored Mar 30, 2024
    Configuration menu
    Copy the full SHA
    d5d70bd View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. More table conversions (#2115)

    * Convert tables for Projects, Images, Instances
    
    * convert NetworkingTab
    
    * convert Storage tab
    
    * convert Snapshots page
    
    * Convert VPC page
    
    * convert VPC Subnet tab
    
    * convert SSH Keys page
    
    * convert Silo Images page
    
    * convert Disks tab
    
    * convert Racks tab, though not sure we're using it
    
    * convert Sleds tab
    
    * convert Sled Instances tab
    
    * convert IpPool page; unresolved tsc issue
    
    * convert SiloIDPs tab, but link not quite right yet
    
    * convert Silos page
    
    * small refactor
    
    * use proper LinkCell component for Identity Providers
    
    * Refactor Silo Identity Providers
    
    * Add DefaultPoolCell
    
    * Update type definitions for column helper
    
    * re-name QUeryTable2 and update imports
    
    * Make Floating IP table's name column just render the name, instead of a link
    
    * refactor
    
    * Convert argument in cell accessor from props to info
    
    * Tests passing; remove unused functions
    
    * Remove Cell type
    
    * Remove Cell type from BooleanCell
    
    * Remove LabelCell
    
    * clean up header / id, start extracting static cols
    
    * Extract more staticCols
    
    * clean up some id / header duplication
    
    * memoization of VPC page cols
    
    * consistent naming
    
    * Memoize ImagesPage
    
    * More momoization and moving things around
    
    * move instance networking cols out
    
    * pull out or memoize some more columns
    
    ---------
    
    Co-authored-by: David Crespo <[email protected]>
    charliepark and david-crespo authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    b63c81e View commit details
    Browse the repository at this point in the history
  2. Update dependency @oxide/design-system to v1.4.1 (#2105)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    bf592a3 View commit details
    Browse the repository at this point in the history
  3. simplify column header; fix failing test (#2116)

    simplify header; fix test
    charliepark authored Apr 2, 2024
    Configuration menu
    Copy the full SHA
    8e3a200 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. update firewall filter type/value visual treatment (#2108)

    * update firewall filter type/value visual treatment
    
    * use normal-case on values badges
    
    * keep various filters on one line, with wrapping when needed
    charliepark authored Apr 3, 2024
    Configuration menu
    Copy the full SHA
    95f2e49 View commit details
    Browse the repository at this point in the history
  2. Get rid of pointless Cell type (#2119)

    get rid of pointless Cell type
    david-crespo authored Apr 3, 2024
    Configuration menu
    Copy the full SHA
    1f8b25d View commit details
    Browse the repository at this point in the history
  3. Shared cells (#2121)

    * shared column defs for description, timeCreated, timeModified, size
    
    * now do it the right way
    
    * don't need that nameCol separate anymore
    
    * whoops
    
    * delete some cell files. now we're talkin
    david-crespo authored Apr 3, 2024
    Configuration menu
    Copy the full SHA
    11411bb View commit details
    Browse the repository at this point in the history
  4. Create instance from existing boot disk (#2076)

    * Create instance from existing boot disk
    
    * Remove setting undefined on tab change (for now)
    
    * Improve descriptions
    
    * copy tweaks
    
    * tweak empty states copy, fix diskList prefetch
    
    * Fix issue with sourceType overload on project vs silo images and disks (#2097)
    
    * Fix issue with sourceType collision on project vs silo images and disks
    
    * refactor
    
    * Refactoring, and updating types
    
    * Maintain state of fields across tab navigation (#2100)
    
    * Simplify test; make it work for Safari
    
    * Clean up and add comments
    
    * verify in test that correct image used
    
    * clean up comment
    
    * imageSize -> imageSizeGiB
    
    ---------
    
    Co-authored-by: David Crespo <[email protected]>
    Co-authored-by: Charlie Park <[email protected]>
    3 people authored Apr 3, 2024
    Configuration menu
    Copy the full SHA
    2cfc8ee View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    99173b9 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b22ca1d View commit details
    Browse the repository at this point in the history
Loading