Implement Scope->getPhpVersion()

Author: staabm

src/Analyser/MutatingScope.php

@@ -5721,4 +5721,27 @@ public function getIterableValueType(Type $iteratee): Type
 		return $iteratee->getIterableValueType();
 	}
 
+	public function getPhpVersion(): PhpVersion
+	{
+		$versionId = $this->getType(new ConstFetch(new Name('PHP_VERSION_ID')));
+		if ($versionId instanceof IntegerRangeType && $versionId->getMin() !== null) {
+			return new PhpVersion($versionId->getMin(), PhpVersion::SOURCE_RUNTIME);
+		}
+
+		$scalars = $versionId->getConstantScalarValues();
+		if ($scalars !== []) {
+			$ints = [];
+			foreach($scalars as $scalar) {
+				if (!is_int($scalar)) {
+					throw new ShouldNotHappenException();
+				}
+				$ints[] = $scalar;
+			}
+
+			return new PhpVersion(min($ints), PhpVersion::SOURCE_RUNTIME);
+		}
+
+		return $this->phpVersion;
+	}
+
 }

src/Analyser/Scope.php

@@ -6,6 +6,7 @@
 use PhpParser\Node\Expr;
 use PhpParser\Node\Name;
 use PhpParser\Node\Param;
+use PHPStan\Php\PhpVersion;
 use PHPStan\Reflection\ClassConstantReflection;
 use PHPStan\Reflection\ClassMemberAccessAnswerer;
 use PHPStan\Reflection\ClassReflection;
@@ -136,4 +137,6 @@ public function filterByFalseyValue(Expr $expr): self;
 
 	public function isInFirstLevelStatement(): bool;
 
+	public function getPhpVersion(): PhpVersion;
+
 }

src/Rules/Methods/FinalPrivateMethodRule.php

@@ -5,7 +5,6 @@
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
 use PHPStan\Node\InClassMethodNode;
-use PHPStan\Php\PhpVersion;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use function sprintf;
@@ -14,12 +13,6 @@
 final class FinalPrivateMethodRule implements Rule
 {
 
-	public function __construct(
-		private PhpVersion $phpVersion,
-	)
-	{
-	}
-
 	public function getNodeType(): string
 	{
 		return InClassMethodNode::class;
@@ -28,7 +21,7 @@ public function getNodeType(): string
 	public function processNode(Node $node, Scope $scope): array
 	{
 		$method = $node->getMethodReflection();
-		if (!$this->phpVersion->producesWarningForFinalPrivateMethods()) {
+		if (!$scope->getPhpVersion()->producesWarningForFinalPrivateMethods()) {
 			return [];
 		}