Check additional assign of promoted readonly property

Author: ondrejmirtes

src/Analyser/NodeScopeResolver.php

@@ -546,6 +546,7 @@ private function processStmtNode(
 						$scope->getClassReflection()->isReadOnly(),
 						false,
 					), $methodScope);
+					$methodScope = $methodScope->assignExpression(new PropertyInitializationExpr($param->var->name), new MixedType(), new MixedType());
 				}
 			}
 

src/Node/ClassPropertiesNode.php

@@ -99,6 +99,7 @@ public function getUninitializedProperties(
 		$classReflection = $scope->getClassReflection();
 
 		$properties = [];
+		$originalProperties = [];
 		foreach ($this->getProperties() as $property) {
 			if ($property->isStatic()) {
 				continue;
@@ -109,6 +110,7 @@ public function getUninitializedProperties(
 			if ($property->getDefault() !== null) {
 				continue;
 			}
+			$originalProperties[$property->getName()] = $property;
 			if ($property->isPromoted()) {
 				continue;
 			}
@@ -139,7 +141,6 @@ public function getUninitializedProperties(
 		$methodsCalledFromConstructor = $this->getMethodsCalledFromConstructor($classReflection, $this->methodCalls, $constructors);
 		$prematureAccess = [];
 		$additionalAssigns = [];
-		$originalProperties = $properties;
 
 		foreach ($this->getPropertyUsages() as $usage) {
 			$fetch = $usage->getFetch();

tests/PHPStan/Rules/Properties/MissingReadOnlyPropertyAssignRuleTest.php

@@ -108,6 +108,10 @@ public function testRule(): void
 				'Readonly property MissingReadOnlyPropertyAssign\FooTraitClass::$doubleAssigned is already assigned.',
 				149,
 			],
+			[
+				'Readonly property MissingReadOnlyPropertyAssign\AdditionalAssignOfReadonlyPromotedProperty::$x is already assigned.',
+				188,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Properties/data/missing-readonly-property-assign.php

@@ -179,3 +179,13 @@ class BarClass
 	use BarTrait;
 
 }
+
+class AdditionalAssignOfReadonlyPromotedProperty
+{
+
+	public function __construct(private readonly int $x)
+	{
+		$this->x = 2;
+	}
+
+}