Skip to content

Conversation

@hirohira9119
Copy link
Contributor

Closes #266

As discussed in #266 the current configuration causes tests and results folders to be installed alongside the package.
This PR updates pyproject.toml to explicitly install only the choreographer package, preventing unintended directories (tests, results) from being included in the distribution.

@ayjayt
Copy link
Collaborator

ayjayt commented Nov 9, 2025

So same effect, I changed strategy:

  1. I chose not to use packages= because by specification you're supposedly to list all sub-packages (even tho our build system doesn't require it, it complained).
  2. I turned off namespaces
  3. I moved to a src directory
  4. I made the resources/ data folder a python subpackage by including __init__.py

Runnig uv build --wheel will show the output- remember to clear your build/ as, unfortunately, setuptools doesn't do that for you.

@ayjayt ayjayt merged commit 4a2ee4f into plotly:main Nov 9, 2025
4 checks passed
@hirohira9119 hirohira9119 deleted the fix_packaging branch November 9, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unintended installation of results and tests folders with Choreographer

2 participants