Added persistence callback test.

Author: nickmelnikov82

dash/dash-renderer/src/observers/executedCallbacks.ts

@@ -36,7 +36,11 @@ import {ICallback, IStoredCallback} from '../types/callbacks';
 import {updateProps, setPaths, handleAsyncError} from '../actions';
 import {getPath, computePaths} from '../actions/paths';
 
-import {applyPersistence, prunePersistence, setPersistance} from '../persistence';
+import {
+    applyPersistence,
+    prunePersistence,
+    setPersistance
+} from '../persistence';
 import {IStoreObserverDefinition} from '../StoreObserver';
 
 const observer: IStoreObserverDefinition<IStoreState> = {
@@ -66,7 +70,7 @@ const observer: IStoreObserverDefinition<IStoreState> = {
             const {props} = applyPersistence({props: updatedProps}, dispatch);
 
             // Save props to storage if persistance is active.
-            setPersistance(path(itempath, layout), updatedProps, dispatch)
+            setPersistance(path(itempath, layout), updatedProps, dispatch);
 
             dispatch(
                 updateProps({

dash/dash-renderer/src/persistence.js

@@ -339,13 +339,15 @@ export function setPersistance(layout, newProps, dispatch) {
                 if (storage.hasItem(valsKey)) {
                     originalVal = storage.getItem(valsKey)[1];
                     if (newVal !== originalVal) {
-                        storage.setItem(valsKey, [newVal, originalVal], dispatch);
+                        storage.setItem(
+                            valsKey,
+                            [newVal, originalVal],
+                            dispatch
+                        );
+                    } else {
+                        storage.removeItem(valsKey);
                     }
-                    else {
-                        storage.removeItem(valsKey)
-                    }
-                }
-                else {
+                } else {
                     storage.setItem(valsKey, [newVal, originalVal], dispatch);
                 }
             }

tests/integration/renderer/test_persistence.py

@@ -558,3 +558,64 @@ def update_container2(n_clicks):
     # persistenceTransforms should return upper case strings
     dash_duo.wait_for_text_to_equal("#component-propName", "ALPACA")
     dash_duo.wait_for_text_to_equal("#component-propPart", "ARTICHOKE")
+
+
+def test_rdps014_save_callback_persistence(dash_duo):
+    app = dash.Dash(__name__)
+
+    def make_input(persistence):
+        return dcc.Input(id="persisted", value="a", persistence=persistence)
+
+    app.layout = html.Div(
+        [
+            dcc.Input(id="persistence-val", value=""),
+            dcc.Input(id="persistence-key", value=""),
+            html.Div(make_input(""), id="persisted-container"),
+            html.Div(id="out"),
+        ]
+    )
+
+    # this is not a good way to set persistence, as it doesn't allow you to
+    # get the right initial value. Much better is to update the whole component
+    # as we do in the previous test case... but it shouldn't break this way.
+    @app.callback(
+        Output("persisted", "persistence"), [Input("persistence-key", "value")]
+    )
+    def set_persistence(val):
+        return val
+
+    @app.callback(Output("persisted", "value"), [Input("persistence-val", "value")])
+    def set_value(val):
+        return val
+
+    @app.callback(Output("out", "children"), [Input("persisted", "value")])
+    def set_out(val):
+        return val
+
+    dash_duo.start_server(app)
+
+    dash_duo.wait_for_text_to_equal("#out", "")
+
+    dash_duo.find_element("#persistence-key").send_keys("a")
+    time.sleep(0.2)
+    assert not dash_duo.get_logs()
+    dash_duo.wait_for_text_to_equal("#out", "")
+    dash_duo.find_element("#persistence-val").send_keys("alpaca")
+    dash_duo.wait_for_text_to_equal("#out", "alpaca")
+
+    dash_duo.find_element("#persistence-key").send_keys("b")
+    dash_duo.wait_for_text_to_equal("#out", "")
+    dash_duo.clear_input("#persistence-val")
+    dash_duo.find_element("#persistence-val").send_keys("artichoke")
+    dash_duo.wait_for_text_to_equal("#out", "artichoke")
+
+    # no persistence, still goes back to original value
+    dash_duo.clear_input("#persistence-key")
+    dash_duo.wait_for_text_to_equal("#out", "")
+
+    # apricot and artichoke saved
+    dash_duo.find_element("#persistence-key").send_keys("a")
+    dash_duo.wait_for_text_to_equal("#out", "alpaca")
+    dash_duo.find_element("#persistence-key").send_keys("b")
+    assert not dash_duo.get_logs()
+    dash_duo.wait_for_text_to_equal("#out", "artichoke")