Skip to content

front-matter-ci shouldn't look under jupyter #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolaskruchten opened this issue Nov 1, 2019 · 1 comment
Closed

front-matter-ci shouldn't look under jupyter #1580

nicolaskruchten opened this issue Nov 1, 2019 · 1 comment
Assignees
@jdamiba

Comments

@nicolaskruchten
Copy link
Contributor

We discussed this in Slack https://plotly.slack.com/archives/DC96RUGSV/p1572392795005800 but upon further reflection, I think we can safely skip the files under python/chart-studio which have their front-matter stored in jupyter. These files are ignored by Jekyll I believe.

Actually, we should confirm that _posts/python/chart-studio/*md are ignored by Jekyll by adding them to the excludes in _config.yml just like the *Rmd files :)
@nicolaskruchten nicolaskruchten mentioned this issue Nov 1, 2019
Closed
@jdamiba
Copy link
Contributor

jdamiba commented Nov 15, 2019

closed by 7a06805#diff-fc3edd654e550950075d7f68b9d88abe

@jdamiba jdamiba closed this as completed Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdamiba jdamiba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicolaskruchten @jdamiba