Skip to content

inline Javascript examples (no more embedded CodePens) #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolaskruchten opened this issue Nov 6, 2019 · 2 comments
Closed

inline Javascript examples (no more embedded CodePens) #1587

nicolaskruchten opened this issue Nov 6, 2019 · 2 comments
Assignees
@jdamiba

Comments

@nicolaskruchten
Copy link
Contributor

JS examples should be rendering plots "in line" in the page so that they always match the displayed code, rather than embedding an external CodePen which easily gets out of date.
@jdamiba
Copy link
Contributor

jdamiba commented Nov 7, 2019 •
edited
Loading

This will require refactoring lines 24-35 of auto_examples.html to inline a script tag rather than an iframe with codepen embed.

This shouldn't be an issue as the plotly.js library is present in the browser environment.

This change will allow us to drop the plot_url front-matter from the JS posts.

@jdamiba jdamiba mentioned this issue Dec 9, 2019
Closed
5 tasks
@jdamiba
Copy link
Contributor

jdamiba commented Jan 6, 2020

This issue has been addressed.

@jdamiba jdamiba closed this as completed Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdamiba jdamiba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inline JS example charts and add edit on codepen button plotly/documentation
2 participants
@nicolaskruchten @jdamiba