updating mapbox token #8

jdamiba · 2020-01-06T18:59:23Z

The purpose of this PR is to use a new mapbox token with URL restrictions. As a bonus, existing references to the key in version control have been removed for environment variables in CircleCI.

nicolaskruchten · 2020-01-07T16:22:00Z

r/2019-09-20-mapbox-layers.Rmd

@@ -164,14 +131,31 @@ p <- us_cities %>%
 p
 ```

+### Mapbox Access Tokens and When You Need Them


let's move this back up to the top plz

Moved to top.

remove mapbox token from ci using correct attribute name for mapbox token moving access token paragraph to top of mapbox-layers example re-adding token to examples that need it

nicolaskruchten · 2020-01-09T01:40:32Z

r/2017-01-19-buttons.Rmd

+mapboxToken <- paste(readLines("../.mapbox_token"), collapse="")    # You need your own token
+
+# Setting mapbox token for R environment 
+Sys.setenv("MAPBOX_TOKEN" = mapboxToken)


So I'm pretty sure that either this Sys.setenv line or the config(accesstoken = mapboxToken) line are required but not both, just like in Javascript. Can you please update these docs to use one or the other and actually document this behaviour in the mapbox-layers file?

From testing in my local dev environment, it seems like Sys.setenv is not a valid way of passing the token.

Edit: this turns out to be the case only if using the plot_mapbox() call signature instead of the plot_ly call signature.

nicolaskruchten · 2020-01-09T01:42:42Z

r/2019-09-20-mapbox-layers.Rmd

-        <li> `layout.mapbox.layers` is an array that defines more layers that are by default rendered above the traces in `data` (although this can also be controlled via the `below` attribute).</li>
-    </ol>
-
-
 ### Mapbox Access Tokens and When You Need Them

  The word "mapbox" in the trace names and `layout.mapbox` refers to the Mapbox.js open-source library. If your basemap in `layout.mapbox.style` uses data from the Mapbox *service*, then you will need to register for a free account at https://mapbox.com/ and obtain a Mapbox Access token. This token should be provided either in `mapboxAccessToken`  in `setPlotConfig` function, or as a variable that would be passed as an argument of `newPlot`.


This paragraph appears to be the one from the JS docs... newPlot isn't an R function and neither is setPlotConfig so let's change it to match the behaviour of the R library please, including the two ways of setting the token :)

nicolaskruchten · 2020-01-09T01:43:21Z

r/2019-09-23-mapbox-density.Rmd

@@ -42,10 +33,6 @@ library(plotly)
 packageVersion('plotly')
 ```

-### Mapbox Access Token
-
-To plot on Mapbox maps with Plotly you "may" need a Mapbox account and a public [Mapbox Access Token](https://www.mapbox.com/studio). See our [Mapbox Map Layers](/r/mapbox-layers/) documentation for more information.


these warning paragraphs should stay, even if the page doesn't include a map that requires a token, because some values of style require one.

r/2019-09-27-lines-on-mapbox.Rmd

nicolaskruchten · 2020-01-09T01:52:03Z

r/2017-02-27-scattermapbox.Rmd

 ```{r}
 library(plotly)
 packageVersion('plotly')
 ```

-### Mapbox Access Token
+### Mapbox Access Tokens and When You Need Them


the reference version of this paragraph should (and does?) live in the /r/mapbox-layers/ and should be linked to from here via the cut and paste "you may need a mapbox token" paragraph in some of the other pages.

nicolaskruchten · 2020-01-09T21:31:13Z

CI is failing and there's a conflict atm

jdamiba · 2020-01-09T22:04:20Z

I got CI to pass again and resolved the conflict.

r/2017-01-19-buttons.Rmd

DESCRIPTION

r/2019-09-27-lines-on-mapbox.Rmd

nicolaskruchten · 2020-01-10T14:13:29Z

r/2019-09-20-mapbox-layers.Rmd


-  The word "mapbox" in the trace names and `layout.mapbox` refers to the Mapbox.js open-source library. If your basemap in `layout.mapbox.style` uses data from the Mapbox *service*, then you will need to register for a free account at https://mapbox.com/ and obtain a Mapbox Access token. This token should be provided either in `mapboxAccessToken`  in `setPlotConfig` function, or as a variable that would be passed as an argument of `newPlot`.


The first two sentences here are important and were lost in the shuffle.

nicolaskruchten · 2020-01-10T14:14:55Z

r/2019-09-20-mapbox-layers.Rmd

+
+The map is composed of layers of three different types.
+<ol>
+  <li> the `layout(mapbox(style))` call signature defines the lowest layers, also known as your "base map"</li>


this block needs to move back up above the "Mapbox Access Tokens and When You Need Them" because this is where we introduce style.

Moved back above.

nicolaskruchten · 2020-01-10T14:16:28Z

r/2019-09-20-mapbox-layers.Rmd

+<ol>
+  <li> the `layout(mapbox(style))` call signature defines the lowest layers, also known as your "base map"</li>
+  <li> The various traces in the `plot_ly` call signature are by default rendered above the base map (this can be controlled via the use of `below` attribute).</li>
+  <li> the `layout(mapbox(layers()))` call signature is an array that defines more layers that are by default rendered above the traces in `data` (although this can also be controlled via the `below` attribute).</li>


this usage of "call signature" doesn't make sense... A call signature is basically the name and layout of arguments you pass to a function, so you can't say it "is an array". You can say something like "when calling layout(mapbox(layers())) you need to pass in an array" or something like that.

nicolaskruchten · 2020-01-10T14:17:42Z

r/2019-09-20-mapbox-layers.Rmd


-Here is the same example, with in addition, a WMS layer from Environment Canada which displays near-real-time radar imagery in partly-transparent raster tiles, rendered above the `go.Scattermapbox` trace, as is the default:
+This example uses the same basemap as the one above. However, in this case, partly-transparent raster tiles are rendered above the trace as well.


This change loses the explanation of what the top layer is

Re-added specifics about top layer.

nicolaskruchten · 2020-01-10T15:08:33Z

OK let's ship this thing. 💃

jdamiba mentioned this pull request Jan 6, 2020

Mapbox token plotly/documentation#1647

Closed

jdamiba force-pushed the update-mapbox-token branch from e594d84 to 9d0ad9c Compare January 6, 2020 21:43

jdamiba requested a review from nicolaskruchten January 6, 2020 21:46

nicolaskruchten reviewed Jan 7, 2020

View reviewed changes

updating token

603b870

remove mapbox token from ci using correct attribute name for mapbox token moving access token paragraph to top of mapbox-layers example re-adding token to examples that need it

jdamiba force-pushed the update-mapbox-token branch from cfe8120 to 603b870 Compare January 7, 2020 17:00

nicolaskruchten reviewed Jan 9, 2020

View reviewed changes

r/2019-09-27-lines-on-mapbox.Rmd Show resolved Hide resolved

nicolaskruchten reviewed Jan 9, 2020

View reviewed changes

Joseph Damiba added 3 commits January 9, 2020 15:25

changes in response to PR review- reorg structure of maps docs

8ff0958

typo

b3bf29e

use env variable

38037c6

Joseph Damiba and others added 2 commits January 9, 2020 16:42

Merge branch 'master' into update-mapbox-token

36a7f1a

add listviewer to dependencies

9bdb137

nicolaskruchten reviewed Jan 10, 2020

View reviewed changes

r/2017-01-19-buttons.Rmd Outdated Show resolved Hide resolved

nicolaskruchten reviewed Jan 10, 2020

View reviewed changes

DESCRIPTION Show resolved Hide resolved

nicolaskruchten reviewed Jan 10, 2020

View reviewed changes

r/2019-09-27-lines-on-mapbox.Rmd Outdated Show resolved Hide resolved

Joseph Damiba added 2 commits January 10, 2020 07:48

removing block mistakenly added to resolve merge conflict

1ed3847

replaying may in quotes with italics

8f0624d

nicolaskruchten reviewed Jan 10, 2020

View reviewed changes

Joseph Damiba added 2 commits January 10, 2020 09:43

reorganizing mapbox-layers doc

dedeb6f

using dot notation for attributes

99fabef

jdamiba merged commit e1f8ec9 into master Jan 10, 2020

jdamiba deleted the update-mapbox-token branch January 10, 2020 15:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

updating mapbox token #8

updating mapbox token #8

jdamiba commented Jan 6, 2020 •

edited

Loading

nicolaskruchten Jan 7, 2020

jdamiba Jan 9, 2020

nicolaskruchten Jan 9, 2020

jdamiba Jan 9, 2020 •

edited

Loading

nicolaskruchten Jan 9, 2020

nicolaskruchten Jan 9, 2020

nicolaskruchten Jan 9, 2020

nicolaskruchten commented Jan 9, 2020

jdamiba commented Jan 9, 2020

nicolaskruchten Jan 10, 2020

jdamiba Jan 10, 2020

nicolaskruchten Jan 10, 2020

jdamiba Jan 10, 2020

nicolaskruchten Jan 10, 2020

jdamiba Jan 10, 2020

nicolaskruchten Jan 10, 2020

jdamiba Jan 10, 2020

nicolaskruchten commented Jan 10, 2020


		The word "mapbox" in the trace names and `layout.mapbox` refers to the Mapbox.js open-source library. If your basemap in `layout.mapbox.style` uses data from the Mapbox service, then you will need to register for a free account at https://mapbox.com/ and obtain a Mapbox Access token. This token should be provided either in `mapboxAccessToken` in `setPlotConfig` function, or as a variable that would be passed as an argument of `newPlot`.


		Here is the same example, with in addition, a WMS layer from Environment Canada which displays near-real-time radar imagery in partly-transparent raster tiles, rendered above the `go.Scattermapbox` trace, as is the default:
		This example uses the same basemap as the one above. However, in this case, partly-transparent raster tiles are rendered above the trace as well.

updating mapbox token #8

updating mapbox token #8

Conversation

jdamiba commented Jan 6, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jdamiba Jan 9, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicolaskruchten commented Jan 9, 2020

jdamiba commented Jan 9, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicolaskruchten commented Jan 10, 2020

jdamiba commented Jan 6, 2020 •

edited

Loading

jdamiba Jan 9, 2020 •

edited

Loading