Skip to content

Search modal doesn't close when link points to current page #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolaskruchten opened this issue Mar 30, 2020 · 0 comments · Fixed by plotly/graphing-library-docs#47
Closed

Search modal doesn't close when link points to current page #1681

nicolaskruchten opened this issue Mar 30, 2020 · 0 comments · Fixed by plotly/graphing-library-docs#47
Assignees
@jdamiba

Comments

@nicolaskruchten
Copy link
Contributor

If you do a search from the figure reference page and click on a link in the figure reference results, the modal doesn't close because there's no navigation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdamiba jdamiba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make sure search modal closes on click plotly/graphing-library-docs
2 participants
@nicolaskruchten @jdamiba