-
-
Notifications
You must be signed in to change notification settings - Fork 67
change font from campaign to open sans #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Did you check out the Percy diffs here? no more Jubilat... |
The Percy diffs look good to me now, just want to address the one comment above and we can merge. |
oh my mistake guys, in the typekit project, i didn't include the 500 font-weight, that previously used to be there.. its corrected now, you can see them in the typekit file. so you shouldn't need those jubilat declarations anymore @jdamiba, just that import statement, could you try again? |
OK so now no more Jubilat in Percy. We should be able to get Jubilat in Percy just by using the style info from the typekit CSS. |
Per our conversation this morning, I have reverted to inlining the same typography CSS as is used on |
Looks good, thanks! |
closes plotly/documentation#1684