Skip to content

change font from campaign to open sans #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2020
Merged

Conversation

jdamiba
Copy link
Contributor

@jdamiba jdamiba commented Apr 29, 2020

@jdamiba jdamiba requested a review from nicolaskruchten April 29, 2020 18:13
@nicolaskruchten
Copy link
Contributor

Did you check out the Percy diffs here? no more Jubilat...

@nicolaskruchten
Copy link
Contributor

The Percy diffs look good to me now, just want to address the one comment above and we can merge.

@VeraZab
Copy link

VeraZab commented Apr 30, 2020

oh my mistake guys, in the typekit project, i didn't include the 500 font-weight, that previously used to be there.. its corrected now, you can see them in the typekit file.

so you shouldn't need those jubilat declarations anymore @jdamiba, just that import statement, could you try again?

@nicolaskruchten
Copy link
Contributor

OK so now no more Jubilat in Percy. We should be able to get Jubilat in Percy just by using the style info from the typekit CSS.

@jdamiba
Copy link
Contributor Author

jdamiba commented May 4, 2020

Per our conversation this morning, I have reverted to inlining the same typography CSS as is used on dash.plotly.com here. Also made sure that the headings are in Jubliat, as discussed.

@nicolaskruchten
Copy link
Contributor

Looks good, thanks!

@nicolaskruchten nicolaskruchten merged commit b293c8f into master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

campaign font to be replaced with Open Sans
3 participants