Skip to content

Publish tagged releases to a container registry #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jawnsy opened this issue Jul 25, 2023 · 5 comments
Open

Publish tagged releases to a container registry #528

jawnsy opened this issue Jul 25, 2023 · 5 comments

Comments

@jawnsy
Copy link

jawnsy commented Jul 25, 2023

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

There's a workflow that builds container images and publishes them to GitHub's container registry. However, even though there are version tags (and the build runs with those tags), the versioned tags are not published.

Describe the solution you'd like
A clear and concise description of what you want to happen.

It would be nice to have tags we can use, like: ghcr.io/postgresml/pgcat:1, ghcr.io/postgresml/pgcat:1.0.0, ghcr.io/postgresml/pgcat:1.1.0, etc.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

We can pin to a digest and always use the latest tag, but it's a lot less straightforward to know when a given release is "recommended" (users generally assume that tagged releases are better than "whatever the latest main branch build is")

Additional context
Add any other context or screenshots about the feature request here.

@levkk
Copy link
Contributor

levkk commented Jul 25, 2023

We tried to do this recently, but apparently it didn't work: #508

A PR for this is absolutely welcome.

@sebastianwebber
Copy link
Contributor

it looks like that the CI was triggered correctly: https://github.com/postgresml/pgcat/actions/runs/5659957126/job/15334598381

Should we add so many tags. Checking current setup we will generate a tag for:

  • Each commit hash
  • nightly
  • tag
  • branch
  • pr id
  • lastest that will point to the latest build of the main branch

Is not the case just to:

  1. use latest for the latest stable tag?
  2. use edge to the latest commit?
  3. a tag for every new tag in the project?

@mpfeil
Copy link
Contributor

mpfeil commented Aug 5, 2023

@sebastianwebber @levkk if you want to I can open a PR with this suggestions next week.

@jawnsy
Copy link
Author

jawnsy commented Aug 22, 2023

I'm not too familiar with how Docker generates its metadata using the plugin, but looking at the last run from a few weeks ago, the only tag being built is the hashed tag:

image

It only has one tag output (ghcr.io/postgresml/pgcat:1f2c6507f7fb5461df1a599c0b380aa114597bb5), and I'd have expected there to be multiple tags (the hash, latest, as well as a versioned tag)

Only the tags for latest, the branch (main), and the hash seem to be making it to the repository for some reason:

image

@smcgivern
Copy link
Contributor

I think this is fixed with the latest tagged release 🎉

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants