To parse Vue SFC, we need paser everything as RAW_TEXT first, then parse template?

To parse Vue SFC, we need paser everything as RAW_TEXT first, then parse template?

Yes.

I'm not a Vue user, but there are claims that it supports // comments, so tags inside those should be not parsed as tags. Can somebody confirm or deny this?

I guess it's possible that <template> contains script/style, if so on template parsing, we just use getTagContentType: undefined, it will work like before, right?

@thorn0 I'm not sure about //, but I can confirm it supports /* */, I saw one last week , from my work. To make it work with prettier, I changed it to html style comment.

Here

I guess it's possible that <template> contains script/style, if so on template parsing, we just use getTagContentType: undefined, it will work like before, right?

Right, getTagContentType defaults to the content type defined in the HTML spec.

I'm not a Vue user, but there are claims that it supports // comments, so tags inside those should be not parsed as tags. Can somebody confirm or deny this?

const {parse} = require("@vue/compiler-sfc"); // 3.0.0-beta.2
const parsed = parse(`
<template><div></div></template>
<script>export default { }</script>
// <abc>
<style></style>
`);
console.log(parsed.errors) // ["SyntaxError: Element is missing end tag (4:4)"]

I'm not sure about //, but I can confirm it supports /* */, I saw one last week , from my work. To make it work with prettier, I changed it to html style comment.

Here

See https://vue-loader.vuejs.org/spec.html#comments.

I'll merge this PR tomorrow if there is no objection/question.

I checked the "Vue SFC Spec" about comments before, but people actually use js style comments, and at least it works in @vue/cli AFAIK.

Relying on the implementation detail does not look like a good idea, I think we should follow the spec and push people to use the correct comment style just like what you did.

Looking forward to see improve vue parse with this.

👉 https://github.com/ikatyang/angular-html-parser/releases/tag/v1.5.0

@ikatyang Thank you!!