Skip to content

Accessibility: Color contrast is poor when selecting editor text in high contrast mode #3413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dsaw opened this issue Mar 22, 2025 · 1 comment
Labels

Comments

@dsaw
Copy link

dsaw commented Mar 22, 2025

p5.js version

No response

What is your operating system?

Windows

Web browser and version

No response

Actual Behavior

When switching to high contrast mode in p5.editor.js, selecting the text using the cursor changes the selection background to a light color, but the text color is not changed in that selection.

Image

Expected Behavior

The color contrast should be as per recommended standard (https://webaim.org/resources/contrastchecker/) and the text should be clearly visible even in high contrast mode. The comment text is barely visible/readable for example.

Steps to reproduce

Steps:

1.Change p5.editor.js to high contrast mode in preference modal 2.Select a text in editor 3. View that the text is barely visible inside the selection as the selection rectange is light color.

Snippet:

// Paste your code here :)
@dsaw dsaw added the Bug label Mar 22, 2025
@dsaw dsaw changed the title Color contrast is poor when selecting editor text in high contrast mode Accessibility: Color contrast is poor when selecting editor text in high contrast mode Mar 22, 2025
@Harshit-7373
Copy link
Contributor

Harshit-7373 commented Mar 22, 2025

@dsaw This issue has been resolved in this pull request :- https://github.com/processing/p5.js-web-editor/pull/3396

The pull request has also been merged.

@dsaw dsaw closed this as completed Mar 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants