-
Notifications
You must be signed in to change notification settings - Fork 111
Documentation for += #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @soegaard and thanks for bringing this up again.
Consistency with the assignment reference is a compelling goal. I propose the following: Syntax Parameters Note that this change should be made for all the compound assignment operators included in the documentation: cc @Arya-Gupta if you're still interested to make a PR for this you're welcome to do so :) |
Thanks @SableRaf, I'll get onto this asap. |
Hey @SableRaf, I've finished working on this issue. |
Thanks for your contribution! I'll be looking into it right now. |
@Arya-Gupta, I'm sorry but I am unable to merge your pull request (#417). Changes to the documentation should go in the JavaDoc on the Processing repo (see the README on updating the reference). Apologies for not making that clearer earlier. Would you mind making those changes over there? Also, just a heads up that we're having a bit of an issue at the moment with the Doclet script that generates the documentation. Changes to the JavaDoc can be merged but they won't show up on the website until we get the script fixed. We're actively working on getting some help to sort it out (if anyone reading this has experience with Doclet scripts, please reply to the issue on the Doclet repo (processing/processing-doclet#1). |
@Arya-Gupta https://github.com/search?q=org%3Aprocessing+Combines+addition+with+assignment&type=code |
Hi @Arya-Gupta and thanks for taking so much time researching this. I'm sorry that it wasn't successful, which is entirely due to the rather complicated way the reference is being generated. I was basing my assessment on this sentence from the README:
but I missed the later part that says:
Well that's awkward 😅 But at least we know the documentation is missing. We will need some input from @REAS or @runemadsen in that particular case. |
Thanks for tagging me in this! I believe that the PR can be merged since all the Java-specific reference content is saved only in the This is how it works: The The rule is that whatever is straight Java should be edited inside this repo and whatever is the Processing API should be edited in the source code. When we fix the Doclet script, I would suggest that we include two new properties in the
This would make it easier to know where to edit the different content items. If we can't find someone to fix the Doclet, we can try giving it a go on our end. |
Thanks @runemadsen! I'll update the README to include these clarifications. Regarding the Doclet script, I have called for help on GitHub, Discourse, and Twitter but so far no one has come forward so I would definitely be grateful for you having another look 🙏 @Arya-Gupta: I have reopened your pull request. There is one tiny correction needed which I noted in a comment on the PR. Once this is fixed I will merge your code. Thanks for you patience and your contribution! |
Fixed @SableRaf. No problem at all. Please do tag me for any doc-related issues. |
Merged in a838211 thanks! |
This is a response to:
processing/processing-docs#847
Please reconsider.
The operator
+=
combines assigment and addition.The documentation explains assignment
=
as:Furthermore, the syntax is listed as:
From the old issue:
The words
variablename
andexpression
are well-known from math.As a math teacher of 20 years I can assure you that concepts - not words - confuse beginners.
The use of
value += value
is confusing since it conflates the concepts of variable and value.If you are afraid of the word
expression
how about:This matches the convention used in the documentation for assignment.
The text was updated successfully, but these errors were encountered: