Skip to content

Consider adding python_requires=">=3.6" to setup.py #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dolfinus opened this issue Sep 19, 2023 · 3 comments · Fixed by #195
Closed

Consider adding python_requires=">=3.6" to setup.py #188

dolfinus opened this issue Sep 19, 2023 · 3 comments · Fixed by #195

Comments

@dolfinus
Copy link
Contributor

#163 dropped support of Python < 3.6, but haven't set minimal Python version in setup.py. Currently only classifiers are set, which are just additional information used for search, these values are not checked during package installation.

Please add this to setup.py:

python_requires=">=3.6",
@dolfinus
Copy link
Contributor Author

dolfinus commented Sep 19, 2023

BTW, Python 3.6 reached end-of-life on 2021-12-23. Why keep supporting this version?

Python 3.7 reached end-of-life too, on 2023-06-27.

@eemeli
Copy link
Member

eemeli commented Sep 19, 2023

Please add this to setup.py:

python_requires=">=3.6",

A PR to this effect would be welcome.

BTW, Python 3.6 reached end-of-life on 2021-12-23. Why keep supporting this version?

Because we've not found reason enough yet to drop the support.

@dolfinus
Copy link
Contributor Author

A PR to this effect would be welcome.

#195

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants