Skip to content

4.34.0: Increase in size of compared to previous version #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ElridgeDMello opened this issue Nov 19, 2021 · 3 comments · Fixed by #229
Closed

4.34.0: Increase in size of compared to previous version #228

ElridgeDMello opened this issue Nov 19, 2021 · 3 comments · Fixed by #229
Labels
status: done This issue is considered resolved.

Comments

@ElridgeDMello
Copy link

Hello,

We noticed that there was an order of magnitude in the size of the build for this project.

https://www.npmjs.com/package/pubnub/v/4.33.1 (6.23 MB)
https://www.npmjs.com/package/pubnub/v/4.34.0 (35.9 MB)

We don't use this project directly but it came in as a transitive dependency. We had to chase down why our build had a dramatic increase between yesterday and today (we deploy to AWS lambda and this size increase pushed our build over the permitted size).

Just wanted to point this out as it might break others too.

Thanks!

@ghost
Copy link

ghost commented Nov 19, 2021

Thanks for the info, I will check it out, not sure why that would change so drastically.

@parfeon parfeon mentioned this issue Nov 19, 2021
@ghost
Copy link

ghost commented Nov 20, 2021

@ElridgeDMello This should be resolved in the next release which will be out very soon. This was caused by changes to our deployment process which we didn't realize would end up on NPM :)

@github-actions
Copy link

@ElridgeDMello this issue is addressed in v4.34.1

@github-actions github-actions bot added the status: done This issue is considered resolved. label Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: done This issue is considered resolved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant