Fix acceptance tests for windows (#349)

* Fix timeout while waiting for windows service to stop

* Fix acceptance tests for windows

Author: florindragos

spec/acceptance/docker_full_spec.rb

@@ -56,7 +56,7 @@
         # Delete all running containers
         shell("#{docker_command} rm -f $(#{docker_command} ps -a -q) || true")
         # Delete all existing images
-        shell("#{docker_command} rmi $(#{docker_command} images -q) || true")
+        shell("#{docker_command} rmi -f $(#{docker_command} images -q) || true")
         # Check to make sure no images are present
         shell("#{docker_command} images | wc -l") do |r|
           expect(r.stdout).to match(/^0|1$/)
@@ -228,20 +228,28 @@ class { 'docker':
         end
       end
 
-
       context 'uninstall docker' do
-        before(:each) do
+        after(:all) do
           @pp =<<-EOS
-            class {'docker':
-              ensure => 'absent'
+            class {'docker': #{docker_args},
+              ensure => 'present'
             }
           EOS
           apply_manifest(@pp, :catch_failures => true)
-          sleep 4
+
+          # Wait for reboot if windows
+          sleep 300 if fact('osfamily') == 'windows'
         end
 
         it 'should uninstall successfully' do
-        shell('docker ps', :acceptable_exit_codes => [1, 127])
+          @pp =<<-EOS
+            class {'docker': #{docker_args},
+              ensure => 'absent'
+            }
+          EOS
+          apply_manifest(@pp, :catch_failures => true)
+          sleep 4
+          shell('docker ps', :acceptable_exit_codes => [1, 127])
         end
       end
     end

templates/windows/download_docker.ps1.erb

@@ -8,10 +8,10 @@ $service = Get-Service "docker" -ErrorAction Ignore
 if ( -not $service ) {
     $cleanInstall = $true
 } elseif ( $service.Status -ne [ServiceProcess.ServiceControllerStatus]::Stopped ) {
-    $timeSpan = New-Object Timespan 0,0,60
+    $timeSpan = New-Timespan -Seconds 60
     try {
         $service.Stop()
-        $service.WaitForStatus([ServiceProcess.ServiceControllerStatus]::Stopped, 60)
+        $service.WaitForStatus([ServiceProcess.ServiceControllerStatus]::Stopped, $timeSpan)
     }
     catch [Management.Automation.MethodInvocationException],[ServiceProcess.TimeoutException] {
         Write-Error "Failed to stop docker service"