Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/puppetlabs-docker
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.1.1
Choose a base ref
...
head repository: puppetlabs/puppetlabs-docker
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.1.2
Choose a head ref
  • 14 commits
  • 5 files changed
  • 7 contributors

Commits on Aug 26, 2021

  1. Configuration menu
    Copy the full SHA
    c22d726 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2021

  1. Configuration menu
    Copy the full SHA
    d433e6f View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2021

  1. Pet rubocop

    smortex committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    23d61da View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f0cbfe1 View commit details
    Browse the repository at this point in the history
  3. Fix Facter::Core::Execution.execute time_limit

    The options hash passed to Facter::Core::Execution.execute expect a
    `time_limit`, not a `limit`:
    https://www.rubydoc.info/gems/facter/Facter/Core/Execution#execute-class_method
    smortex committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    6b48ec5 View commit details
    Browse the repository at this point in the history
  4. Fix docker_worker_join_token evaluation

    When this fact was evaluated, an exception was raised:
    Error: Facter: Error while resolving custom fact fact='docker_worker_join_token', resolution='<anonymous>': private method `execute' called for Facter::Util::Resolution:Class
    
    Switch from Facter::Util::Resolution to Facter::Core::Execution and set
    a time limit of 90s to match the rest of the file.
    smortex committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    9edf10b View commit details
    Browse the repository at this point in the history
  5. Fix CI with stubs modernization

    This make it easier to debug failing unit tests.
    smortex committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    f756598 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #773 from smortex/fix/check-for-nil-value

    Fix facts gathering
    bastelfreak authored Sep 8, 2021
    Configuration menu
    Copy the full SHA
    6e81b7e View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. Prefer timeout to time_limit for Facter::Core::Execution

    Facter 4 documentation and code was inconsistent regarding naming of
    this option.  `limit` and `time_limit` have been replaced by `timeout`
    which also match the option name in previous versions of facter.  The
    old names will output a warning when used, so swith to the new
    terminology now.
    
    Releated PR:
    puppetlabs/facter#2429
    smortex committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    f0fd930 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2021

  1. Configuration menu
    Copy the full SHA
    f805c3e View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2021

  1. Merge pull request #775 from puppetlabs/pdksync_IAC-1598/main/remove_…

    …debian_8_support
    
    pdksync - (IAC-1598) - Remove Support for Debian 8
    daianamezdrea authored Sep 16, 2021
    Configuration menu
    Copy the full SHA
    e124742 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. Merge pull request #774 from smortex/facter-timeout

    Prefer timeout to time_limit for Facter::Core::Execution
    adrianiurca authored Sep 20, 2021
    Configuration menu
    Copy the full SHA
    8440c89 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2021

  1. Release prep v4.1.2

    GitHub Action committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    c6792a1 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #778 from puppetlabs/release-prep

    Release prep v4.1.2
    adrianiurca authored Sep 27, 2021
    Configuration menu
    Copy the full SHA
    f5a06f9 View commit details
    Browse the repository at this point in the history
Loading