-
Notifications
You must be signed in to change notification settings - Fork 83
Comparing changes
Open a pull request
base repository: puppetlabs/puppetlabs-reboot
base: 0.1.7
head repository: puppetlabs/puppetlabs-reboot
compare: 0.1.8
- 15 commits
- 28 files changed
- 5 contributors
Commits on Jul 3, 2014
-
Merge branch '0.1.x' into master
Travis Fields committedJul 3, 2014 Configuration menu - View commit details
-
Copy full SHA for b443249 - Browse repository at this point
Copy the full SHA b443249View commit details
Commits on Aug 12, 2014
-
(MODULES-1247) Support reboot on x86 and x64
- Puppet 3.7 has changed the gem dependency hierarchy, removing gems such as win32-api, windows-api and windows-pr, and updating other gems for FFI compatibility. - One approach would be to update the gems to be in lockstep with Puppet, but that likely prevents the module from working across a wider array of Puppet versions. - Given how little use of the Win32 API this module makes, instead depend on FFI, and create local definitions of the few Win32 functions needed. This will effectively redefine some API definitions already present in other gems BUT will make the module less fragile / susceptible to being broken by a dependency hierarchy owned outside the scope of this module. - Created local FFI definitions for OpenProcess and WaitForSingleObject Moved constant definitions in for WAIT_*, FALSE, SYNCHRONIZE, NULL_HANDLE and ERROR_INVALID_PARAMETER. - Would have liked to additionally remove sys-admin, win32-dir, win32-process, win32-service and win32-taskscheduler gems - but due to current Gem dependency resolution, cannot as these gems are needed by the Puppet gem. These gems are not required for this module.
Configuration menu - View commit details
-
Copy full SHA for 21b9eda - Browse repository at this point
Copy the full SHA 21b9edaView commit details -
(MODULES-1247) CloseHandle on process token
- Add FFI definition for CloseHandle - Ensure that we don't leak handles, by ensuring CloseHandle is called against the handle returned by OpenProcess
Configuration menu - View commit details
-
Copy full SHA for 04ddb74 - Browse repository at this point
Copy the full SHA 04ddb74View commit details -
(MODULES-1247) Update Puppet / PE compatibility
- Given this module now requires FFI, it's important to verify in our MSI packages, which versions shipped with at least 1.9.x. It appears that Puppet Open Source introduced a win32-dir upgrade to 0.4.3 for the release of 3.3.0. Since win32-dir requires FFI, FFI will be present in MSIs released from this point in time: https://github.com/puppetlabs/puppet-win32-ruby/commits/1.9.3/ruby/lib/ruby/gems/1.9.1/gems/ffi-1.9.0-x86-mingw32/ext/ffi_c/ffi.c - Since PE 3.1 ships with Puppet open source 3.3.1, it should also be compatible. - Note that the Gemfile wasn't updated until Puppet open source 3.3.2, but given it's rare to run Puppet from source on Windows, it's safe to ignore that particular discrepancy: puppetlabs/puppet@11f7c51
Configuration menu - View commit details
-
Copy full SHA for 6afd1cf - Browse repository at this point
Copy the full SHA 6afd1cfView commit details
Commits on Aug 14, 2014
-
Merge pull request #44 from Iristyle/ticket/master/modules-1247-reboo…
…t-x64 (MODULES-1247) FFI module - allow to work on x86 / x64
Configuration menu - View commit details
-
Copy full SHA for 39e815b - Browse repository at this point
Copy the full SHA 39e815bView commit details
Commits on Aug 21, 2014
-
Update testing to remove master dependencies
Travis Fields committedAug 21, 2014 Configuration menu - View commit details
-
Copy full SHA for c1164c9 - Browse repository at this point
Copy the full SHA c1164c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36c6cff - Browse repository at this point
Copy the full SHA 36c6cffView commit details
Commits on Aug 22, 2014
-
Add stdlib to git installed modules
Travis Fields committedAug 22, 2014 Configuration menu - View commit details
-
Copy full SHA for 0eaa1d4 - Browse repository at this point
Copy the full SHA 0eaa1d4View commit details -
FM-1788 Bump version and fix test cases for negative testing and abil…
…ity to get stdout
Travis Fields committedAug 22, 2014 Configuration menu - View commit details
-
Copy full SHA for 372bf79 - Browse repository at this point
Copy the full SHA 372bf79View commit details -
Travis Fields committed
Aug 22, 2014 Configuration menu - View commit details
-
Copy full SHA for f7d724b - Browse repository at this point
Copy the full SHA f7d724bView commit details -
Add foss testing and ability to install from arbitrary URL when avail…
…able
Travis Fields committedAug 22, 2014 Configuration menu - View commit details
-
Copy full SHA for 230fed7 - Browse repository at this point
Copy the full SHA 230fed7View commit details
Commits on Aug 25, 2014
-
Merge pull request #45 from cyberious/0.1.x
Test fixes and merging master to 0.1.x
Configuration menu - View commit details
-
Copy full SHA for 5b3049b - Browse repository at this point
Copy the full SHA 5b3049bView commit details -
Merge pull request #46 from cyberious/FossTestingRefactor
Foss testing refactor
Configuration menu - View commit details
-
Copy full SHA for 3a35e6c - Browse repository at this point
Copy the full SHA 3a35e6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bda199 - Browse repository at this point
Copy the full SHA 2bda199View commit details -
Configuration menu - View commit details
-
Copy full SHA for f3722ae - Browse repository at this point
Copy the full SHA f3722aeView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 0.1.7...0.1.8