Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/puppetlabs-reboot
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.1.7
Choose a base ref
...
head repository: puppetlabs/puppetlabs-reboot
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.1.8
Choose a head ref
  • 15 commits
  • 28 files changed
  • 5 contributors

Commits on Jul 3, 2014

  1. Merge branch '0.1.x' into master

    Travis Fields committed Jul 3, 2014
    Configuration menu
    Copy the full SHA
    b443249 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2014

  1. (MODULES-1247) Support reboot on x86 and x64

     - Puppet 3.7 has changed the gem dependency hierarchy, removing gems
       such as win32-api, windows-api and windows-pr, and updating other
       gems for FFI compatibility.
     - One approach would be to update the gems to be in lockstep with
       Puppet, but that likely prevents the module from working across a
       wider array of Puppet versions.
     - Given how little use of the Win32 API this module makes, instead
       depend on FFI, and create local definitions of the few Win32
       functions needed.  This will effectively redefine some API
       definitions already present in other gems BUT will make the module
       less fragile / susceptible to being broken by a dependency
       hierarchy owned outside the scope of this module.
     - Created local FFI definitions for OpenProcess and WaitForSingleObject
       Moved constant definitions in for WAIT_*, FALSE, SYNCHRONIZE,
       NULL_HANDLE and ERROR_INVALID_PARAMETER.
     - Would have liked to additionally remove sys-admin, win32-dir,
       win32-process, win32-service and win32-taskscheduler gems - but due
       to current Gem dependency resolution, cannot as these gems are
       needed by the Puppet gem.  These gems are not required for this
       module.
    Iristyle committed Aug 12, 2014
    Configuration menu
    Copy the full SHA
    21b9eda View commit details
    Browse the repository at this point in the history
  2. (MODULES-1247) CloseHandle on process token

     - Add FFI definition for CloseHandle
     - Ensure that we don't leak handles, by ensuring CloseHandle is called
       against the handle returned by OpenProcess
    Iristyle committed Aug 12, 2014
    Configuration menu
    Copy the full SHA
    04ddb74 View commit details
    Browse the repository at this point in the history
  3. (MODULES-1247) Update Puppet / PE compatibility

     - Given this module now requires FFI, it's important to verify in our
       MSI packages, which versions shipped with at least 1.9.x.  It appears
       that Puppet Open Source introduced a win32-dir upgrade to 0.4.3 for
       the release of 3.3.0.  Since win32-dir requires FFI, FFI will be
       present in MSIs released from this point in time:
       https://github.com/puppetlabs/puppet-win32-ruby/commits/1.9.3/ruby/lib/ruby/gems/1.9.1/gems/ffi-1.9.0-x86-mingw32/ext/ffi_c/ffi.c
     - Since PE 3.1 ships with Puppet open source 3.3.1, it should also be
       compatible.
     - Note that the Gemfile wasn't updated until Puppet open source 3.3.2,
       but given it's rare to run Puppet from source on Windows, it's
       safe to ignore that particular discrepancy:
     puppetlabs/puppet@11f7c51
    Iristyle committed Aug 12, 2014
    Configuration menu
    Copy the full SHA
    6afd1cf View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2014

  1. Merge pull request #44 from Iristyle/ticket/master/modules-1247-reboo…

    …t-x64
    
    (MODULES-1247) FFI module - allow to work on x86 / x64
    cyberious committed Aug 14, 2014
    Configuration menu
    Copy the full SHA
    39e815b View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2014

  1. Update testing to remove master dependencies

    Travis Fields committed Aug 21, 2014
    Configuration menu
    Copy the full SHA
    c1164c9 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' into 0.1.x

    Conflicts:
    	metadata.json
    Travis Fields committed Aug 21, 2014
    Configuration menu
    Copy the full SHA
    36c6cff View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2014

  1. Add stdlib to git installed modules

    Travis Fields committed Aug 22, 2014
    Configuration menu
    Copy the full SHA
    0eaa1d4 View commit details
    Browse the repository at this point in the history
  2. FM-1788 Bump version and fix test cases for negative testing and abil…

    …ity to get stdout
    Travis Fields committed Aug 22, 2014
    Configuration menu
    Copy the full SHA
    372bf79 View commit details
    Browse the repository at this point in the history
  3. Readd linux negative test

    Travis Fields committed Aug 22, 2014
    Configuration menu
    Copy the full SHA
    f7d724b View commit details
    Browse the repository at this point in the history
  4. Add foss testing and ability to install from arbitrary URL when avail…

    …able
    Travis Fields committed Aug 22, 2014
    Configuration menu
    Copy the full SHA
    230fed7 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2014

  1. Merge pull request #45 from cyberious/0.1.x

    Test fixes and merging master to 0.1.x
    hunner committed Aug 25, 2014
    Configuration menu
    Copy the full SHA
    5b3049b View commit details
    Browse the repository at this point in the history
  2. Merge pull request #46 from cyberious/FossTestingRefactor

    Foss testing refactor
    hunner committed Aug 25, 2014
    Configuration menu
    Copy the full SHA
    3a35e6c View commit details
    Browse the repository at this point in the history
  3. Release 0.1.8

    hunner committed Aug 25, 2014
    Configuration menu
    Copy the full SHA
    2bda199 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #47 from hunner/release_0.1.8

    Release 0.1.8
    Morgan Haskel committed Aug 25, 2014
    Configuration menu
    Copy the full SHA
    f3722ae View commit details
    Browse the repository at this point in the history
Loading