Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/puppetlabs-reboot
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.1.0
Choose a base ref
...
head repository: puppetlabs/puppetlabs-reboot
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.2.0
Choose a head ref
  • 20 commits
  • 13 files changed
  • 5 contributors

Commits on Jul 27, 2015

  1. Merge branch 'stable'

    * stable:
      (FM-3084) Prepare 1.1.0 release in support of 2015.2.0
    ferventcoder committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    657f714 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2015

  1. (maint) Guarantee Facter version for old Puppets

    For Puppet older than 3.5.0 on Windows, a facter version at or under
    1.7.5 should be selected for greatest compatibility when requesting
    a gem puppet version and if a facter version has not been specified.
    ferventcoder committed Aug 20, 2015
    Configuration menu
    Copy the full SHA
    7db1869 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2015

  1. (MODULES-2452) Update Beaker Version

    Update the Beaker version to use "2.20" which has an important fix for PE
    installations.
    ferventcoder committed Aug 24, 2015
    Configuration menu
    Copy the full SHA
    a96dda0 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #87 from ferventcoder/maint/master/modsync-changes

    (maint) Guarantee Facter version for old Puppets / (MODULES-2452) Update Beaker Version
    Ryan Gard committed Aug 24, 2015
    Configuration menu
    Copy the full SHA
    e4eb745 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2015

  1. (MODULES-2585) Fix Linux provider failing on Windows

    Provide the path to find the posix provider so that the module works
    jpogran authored and ferventcoder committed Oct 6, 2015
    Configuration menu
    Copy the full SHA
    c96ac7e View commit details
    Browse the repository at this point in the history
  2. (MODULES-2674) Update module install + ca certs

     - In acceptance pre-suite, git clone was previously used to install
       modules, but this is no longer necessary given a pre-suite step that
       installs windows certs for PMT
    Iristyle committed Oct 6, 2015
    Configuration menu
    Copy the full SHA
    cba0518 View commit details
    Browse the repository at this point in the history
  3. (MODULES-2674) Use install_dev_puppet_module_on

     - Previously, the pre-suite module installation used the older
       copy_root_module_to method, but shift gears and use the newer
       Beaker helper.  Also, provide the ability to install from a stubbed
       forge when the forge host is specified, otherwise use the standard
       module SCP
    Iristyle committed Oct 6, 2015
    Configuration menu
    Copy the full SHA
    274bd36 View commit details
    Browse the repository at this point in the history
  4. (MODULES-2674) Add masterless pre-suite for dev

     - Previously, the acceptance suites run were based on either the
        - .beaker-git.cfg which triggers beaker-puppet_install_helper's
        run_puppet_install_helper + module install
        - .beaker-pe.cfg which triggers Beakers install_pe then the same
        module install
    
     - This adds a new options hash and config for installing Puppet that
       behaves very similarly to the poorly named .beaker-git.cfg, and
       installs a Puppet MSI, then uses a local copy of the module source.
       However, the node definition only has a single Windows 2012R2 node
       with no master for testing and uses the 'aio' type for the install.
       This should decrease the feedback loop necessary for local acceptance
       testing.
    
       To exercise this suite, from the root of this repo, run:
    
       PUPPET_INSTALL_TYPE=agent GEM_SOURCE=http://rubygems.delivery.puppetlabs.net bundle exec beaker --preserve-hosts onfail  --options-file ./acceptance/.beaker-masterless.cfg
    Iristyle committed Oct 6, 2015
    Configuration menu
    Copy the full SHA
    73f0fd8 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'ticket/master/MODULES-2585-linux-provider-fails-on-wind…

    …ows'
    
    * ticket/master/MODULES-2585-linux-provider-fails-on-windows:
      (MODULES-2585) Fix Linux provider failing on Windows
    ferventcoder committed Oct 6, 2015
    Configuration menu
    Copy the full SHA
    2906c0a View commit details
    Browse the repository at this point in the history
  6. Merge pull request #90 from Iristyle/ticket/master/MODULES-2674-maste…

    …rless-dev-acceptance-suite
    
    (MODULES-2674) Windows masterless acceptance testing
    ferventcoder committed Oct 6, 2015
    Configuration menu
    Copy the full SHA
    db3bdd2 View commit details
    Browse the repository at this point in the history
  7. (MODULES-2657) Detect Windows computer rename

     - A pending computer rename operation is a trigger for a reboot, even
       though it is not expressed in any of the existing checks.
    
      This is due to the fact that the Windows API GetComputerName function
      reads the NetBIOS name of the computer from the registry on first boot
      and caches it for all of eternity.  See docs at:
    
      https://msdn.microsoft.com/en-us/library/windows/desktop/ms724295(v=vs.85).aspx
    Iristyle committed Oct 6, 2015
    Configuration menu
    Copy the full SHA
    114d153 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #88 from Iristyle/ticket/master/MODULES-2657-compu…

    …ter-rename-pending
    
    (MODULES-2657) Detect Windows computer rename
    ferventcoder committed Oct 6, 2015
    Configuration menu
    Copy the full SHA
    313a8f0 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2015

  1. (MODULES-2658) Detect DSC pending reboot state

     - Use WMI to query the MSFT_DSCLocalConfigurationManager class of the
       DSC namespace to retrieve the LCMState property.  When the LCMState
       is set to 'PendingReboot', then the machine is pending a reboot.
    
       Note that we can only mock out the WMI interactions, and that writing
       a valid acceptance test is not easy at this time given this
       functionality depends on WMF5.  CI pipelines are not yet configured
       with WMF5, so these changes will require some manual validation.
    Iristyle committed Oct 7, 2015
    Configuration menu
    Copy the full SHA
    63145f0 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #91 from Iristyle/ticket/master/MODULES-2658-dsc-l…

    …cmstate-pending
    
    (MODULES-2658) Detect DSC pending reboot state
    ferventcoder committed Oct 7, 2015
    Configuration menu
    Copy the full SHA
    0d8af82 View commit details
    Browse the repository at this point in the history
  3. (MODULES-2659) Detect CCM pending reboot state

      - Use WMI to query the CCM_ClientUtilities class of the CCM ClientSDK
      namespace to call the DetermineIfRebootPending WMI method.  The object
      returned contains a ReturnValue and two flags RebootPending and
      IsHardRebootPending
    
      See the Configuration Manager Client SDK WMI reference for more info:
      https://msdn.microsoft.com/en-us/library/jj885518.aspx
    
      Only unit tests are included since writing an acceptance test requires
      additional dependencies that are difficult to install in this context.
      To manual test, install the System Center Configuration Manager Client
    Iristyle committed Oct 7, 2015
    Configuration menu
    Copy the full SHA
    6f8f7f7 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #92 from Iristyle/ticket/master/MODULES-2659-ccm-c…

    …lientutils-pending
    
    (MODULES-2659) Detect CCM pending reboot state
    ferventcoder committed Oct 7, 2015
    Configuration menu
    Copy the full SHA
    b32f9f3 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2015

  1. Configuration menu
    Copy the full SHA
    eb82a5b View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2015

  1. Merge pull request #93 from ferventcoder/ticket/master/FM-3747-releas…

    …e-1.2.0
    
    (FM-3747) Prepare Supported release 1.2.0
    Iristyle committed Oct 13, 2015
    Configuration menu
    Copy the full SHA
    e9044c2 View commit details
    Browse the repository at this point in the history
  2. (maint) Emit Windows debug messages for pending

     - Prior commits failed to add appropriate debug messages to notify
       what system settings were responsible for setting a system reboot
       state.
    Iristyle committed Oct 13, 2015
    Configuration menu
    Copy the full SHA
    5bcb03a View commit details
    Browse the repository at this point in the history
  3. Merge pull request #94 from Iristyle/maint/master/windows-pending-reb…

    …oot-debug-messages
    
    (maint) Emit Windows debug messages for pending
    ferventcoder committed Oct 13, 2015
    Configuration menu
    Copy the full SHA
    9a658eb View commit details
    Browse the repository at this point in the history
Loading