Skip to content

Commit 7800e7f

Browse files
committed
Very minor tweaks (by-product of reviewing PR #3719).
1 parent bca56c0 commit 7800e7f

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ cmake --build build -j4
9393

9494
Tips:
9595

96-
* You can use `virtualenv` (faster, from PyPI) instead of `venv`
96+
* You can use `virtualenv` (faster, from PyPI) instead of `venv`.
9797
* You can select any name for your environment folder; if it contains "env" it
9898
will be ignored by git.
9999
* If you don't have CMake 3.14+, just add "cmake" to the pip install command.

include/pybind11/pybind11.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1213,7 +1213,7 @@ class module_ : public object {
12131213
PyModule_AddObject(ptr(), name, obj.inc_ref().ptr() /* steals a reference */);
12141214
}
12151215

1216-
using module_def = PyModuleDef;
1216+
using module_def = PyModuleDef; // TODO: Can this be removed (it was needed only for Python 2)?
12171217

12181218
/** \rst
12191219
Create a new top-level module that can be used as the main module of a C extension.
@@ -1241,7 +1241,7 @@ class module_ : public object {
12411241
pybind11_fail("Internal error in module_::create_extension_module()");
12421242
}
12431243
// TODO: Should be reinterpret_steal for Python 3, but Python also steals it again when
1244-
// returned from PyInit_...
1244+
// returned from PyInit_...
12451245
// For Python 2, reinterpret_borrow was correct.
12461246
return reinterpret_borrow<module_>(m);
12471247
}

0 commit comments

Comments
 (0)