Skip to content

Extend comparison-with-callable to types #10364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jacobtylerwalls opened this issue May 4, 2025 · 0 comments
Open

Extend comparison-with-callable to types #10364

jacobtylerwalls opened this issue May 4, 2025 · 0 comments
Labels
Enhancement ✨ Improvement to a component False Negative 🦋 No message is emitted but something is wrong with the code

Comments

@jacobtylerwalls
Copy link
Member

Refs #7724, for def a_func and def b_func we already lint for a_func == b_func as inferior to a_func is b_func, but we should do this for classes as well, e.g. type(x) == list should be inferior to type(x) is list.

More discussion at #10161 (comment).
@jacobtylerwalls jacobtylerwalls added Enhancement ✨ Improvement to a component False Negative 🦋 No message is emitted but something is wrong with the code labels May 4, 2025
@jacobtylerwalls jacobtylerwalls changed the title Extend comparison-with-callable to types Extend comparison-with-callable to types May 4, 2025
@jacobtylerwalls jacobtylerwalls mentioned this issue May 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement ✨ Improvement to a component False Negative 🦋 No message is emitted but something is wrong with the code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jacobtylerwalls