Skip to content

fix(flamegraph): don't ship react-dom #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2022
Merged

Conversation

eh-am
Copy link
Collaborator

@eh-am eh-am commented May 12, 2022

Closes #1101

Plus ships sourcemaps.

@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 462.14 KB (0%) 9.3 s (0%) 2 s (+3.75% 🔺) 11.3 s

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #1102 (37d4601) into main (9c546cf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1102   +/-   ##
=======================================
  Coverage   70.95%   70.95%           
=======================================
  Files          86       86           
  Lines        2939     2939           
  Branches      735      732    -3     
=======================================
  Hits         2085     2085           
  Misses        851      851           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c546cf...37d4601. Read the comment docs.

@eh-am eh-am force-pushed the fix/react-dom-peer-dependency branch from 37d4601 to 7763ded Compare May 12, 2022 18:13
@eh-am eh-am marked this pull request as ready for review May 12, 2022 18:25
@eh-am eh-am merged commit c80240c into main May 12, 2022
@eh-am eh-am deleted the fix/react-dom-peer-dependency branch May 12, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@pyroscope/flamegraph is shipping with react-dom
1 participant