Skip to content

fix: Fix missed style in tags submenu #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2022
Merged

Conversation

Rperry2174
Copy link
Contributor

@Rperry2174 Rperry2174 commented Jun 12, 2022

Missed a style in #1152... This will be easier to automatically check for in tests when we add tags to self profiling in #1137 .

image

also worth noting that in #1136 we started to unify all of the inputs so there is a part of this that may be worth making part of the input component as I had to duplicate it in this pr.

before:
Screen Shot 2022-06-12 at 1 41 16 PM

After:
Screen Shot 2022-06-12 at 1 54 38 PM

@codecov
Copy link

codecov bot commented Jun 12, 2022

Codecov Report

Merging #1154 (53ce41e) into main (869e9c4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1154   +/-   ##
=======================================
  Coverage   70.61%   70.61%           
=======================================
  Files          98       98           
  Lines        3147     3147           
  Branches      804      804           
=======================================
  Hits         2222     2222           
  Misses        921      921           
  Partials        4        4           
Impacted Files Coverage Δ
webapp/javascript/ui/Dropdown.module.scss 61.54% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 869e9c4...53ce41e. Read the comment docs.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 466.68 KB (+0.01% 🔺) 9.4 s (+0.01% 🔺) 2.1 s (+0.88% 🔺) 11.5 s

@Rperry2174 Rperry2174 merged commit 006771b into main Jun 12, 2022
@Rperry2174 Rperry2174 deleted the fix/missed-submenu-style branch June 12, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant