Skip to content

fix: improved nodes coloring by fixing murmur math #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2022
Merged

Conversation

petethepig
Copy link
Collaborator

I don't know how this happened but we introduced this bug at some point. I changed it to proper math. E.g see code here

@petethepig petethepig changed the title fix: proper murmur math fix: improved nodes coloring by fixing murmur math Jul 5, 2022
@petethepig petethepig requested a review from eh-am July 5, 2022 22:38
@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #1214 (8983eef) into main (e83e482) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1214      +/-   ##
==========================================
- Coverage   68.89%   68.89%   -0.00%     
==========================================
  Files         100      100              
  Lines        3269     3268       -1     
  Branches      848      849       +1     
==========================================
- Hits         2252     2251       -1     
  Misses       1014     1014              
  Partials        3        3              
Impacted Files Coverage Δ
...raph/src/FlameGraph/FlameGraphComponent/murmur3.ts 100.00% <100.00%> (ø)
...e-flamegraph/src/FlameGraph/FlameGraphRenderer.tsx 47.80% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e83e482...8983eef. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
webapp/public/assets/app.js 468.65 KB (0%) 9.4 s (0%) 2.1 s (-0.03% 🔽) 11.5 s

@Rperry2174 Rperry2174 self-requested a review July 6, 2022 18:29
Copy link
Contributor

@Rperry2174 Rperry2174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Rperry2174 Rperry2174 merged commit 8ea4f73 into main Jul 6, 2022
@Rperry2174 Rperry2174 deleted the fix-murmur branch July 6, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants