feat: add pprof profiles multiplexing #898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## main #898 +/- ##
=======================================
Coverage 66.09% 66.09%
=======================================
Files 86 86
Lines 3120 3120
Branches 611 611
=======================================
Hits 2062 2062
Misses 1026 1026
Partials 32 32 Continue to review full report at Codecov.
|
|
Oh thank fuck, thank you all. Let me know when it gets into a tagged release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR addresses #818.
It's important to note that this affects only pprof format (Go clients). Profiles of other formats are ingested one by one, making it almost impossible to merge scope-tagged ones (with
profile_idlabel) into "baseline" profiles. This is not a problem as for now because the tracing integration support was announced only for Go; in future we should either implement this logic in the client libraries, or switch to pprof.