Skip to content

feat(webapp): add modal for custom export name #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 14, 2022

Conversation

EgorMozheiko
Copy link
Contributor

Issue: #872

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #965 (8bc1c54) into main (ba568d0) will decrease coverage by 1.06%.
The diff coverage is 36.24%.

@@            Coverage Diff             @@
##             main     #965      +/-   ##
==========================================
- Coverage   70.06%   69.01%   -1.05%     
==========================================
  Files          84       87       +3     
  Lines        2932     3013      +81     
  Branches      604      623      +19     
==========================================
+ Hits         2054     2079      +25     
- Misses        875      931      +56     
  Partials        3        3              
Impacted Files Coverage Δ
webapp/javascript/components/ExportData.tsx 35.16% <11.12%> (-6.32%) ⬇️
...ascript/components/Modals/ModalWithInput/index.tsx 40.00% <40.00%> (ø)
webapp/javascript/ui/Modals/index.ts 39.14% <57.15%> (ø)
webapp/javascript/ui/Modals/Modal.module.css 61.54% <61.54%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba568d0...8bc1c54. Read the comment docs.

@eh-am
Copy link
Collaborator

eh-am commented Mar 22, 2022

/create-server

Copy link
Collaborator

@eh-am eh-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks guide good! I added some minor comments

Visually speaking, what if we make the components closer to what's on the rest of the page?
Like the buttons, the input box etc. Otherwise it feels a little too...disconnected.

image

@eh-am
Copy link
Collaborator

eh-am commented Mar 25, 2022

/create-server

@eh-am
Copy link
Collaborator

eh-am commented Apr 14, 2022

/create-server

@eh-am
Copy link
Collaborator

eh-am commented Apr 14, 2022

Looks good, the only thing I noticed is that for diff it uses "flamegraph" as the default name
image

But merging this anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants