-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
Significant performance degradation in the macOS build #122832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Sound like a duplicate of #122580. |
There are key differences. The other report shows a specific piece of code that runs a little slower and could reasonably be attributed to a skipped PGO path or build noise. This report shows degradation across the board. Local variable reads are 4x slower. This isn't minor. The other report used a local build which would be affected by many factors. This report uses the official The other report used an alpha version. This report focuses on a release-candidate which means that this is what we're about to ship. That makes the level of severity more important. Rather than thinking about dismissing this as a duplicate, a better question is whether it should be marked as a release-blocker. |
Thanks for the additional data points. I think we were considering the other issue to be a release blocker and should have labeled it as such. |
The full pyperformance suite has been run in the other issue, comparing 3.13.0rc1 and 3.12.4 and showed the RC is some 9% slower. See #122580 (comment) Yes, I think it's a release blocker. There's a possible solution in the other issue, building with different flags. |
BTW, thanks again, @rhettinger, for implementing that useful benchmark. I had been using it already in investigating the other report which was also against the python.org builds, later diverging into local test builds. |
Actually, my report used the official installers from Python.org, and focused on the release candidate as well. So, they can be seen as the same overall issue. Thanks for the benchmark to help this out. |
Thanks again for the extremely useful data and the heads-up. Since the performance degradation here appears to the same root cause and solution (which will be available in 3.13.0rc2) as that noted in #122580, I am going to close this as a duplicate and consolidate the discussion there. |
Just tested 3.13rc2 and everything is fixed. Thank you. |
Bug report
Bug description:
The benchmark at
Tools/scripts/var_access_benchmark.py
indicates that something is wrong with the latest build.The versions compared are
3.12.4
versusPython 3.13.0rc1
using the stockmacOS 64-bit universal2 installer
builds published onpython.org
.CPython versions tested on:
3.13
Operating systems tested on:
macOS
The text was updated successfully, but these errors were encountered: