Skip to content

Use unittest instead of pytest everywhere #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jerryzh168 opened this issue Nov 21, 2024 · 4 comments
Open

Use unittest instead of pytest everywhere #1321

jerryzh168 opened this issue Nov 21, 2024 · 4 comments
Assignees

Comments

@jerryzh168
Copy link
Contributor

fbcode is deprecating pytest support so we want to use unittest everywhere to make sure the features are tested in both OSS and fbcode

@osbm
Copy link

osbm commented Jan 25, 2025

Hello @jerryzh168,

I am seeing the usage of both unittest and pytest in the tests now. Is the pytest still the preferred testing library?

If so maybe i can open a PR to migrate all the currently pytest tests. Currently this library uses both these tests.

@jerryzh168
Copy link
Contributor Author

@osbm unittest will be preferred since pytest is deprecated in fbcode. yeah feel free to open a PR to migrate the pytest tests to use unittest, you can also start with just migrating one file before applying the changes to more files I think.

@jcaip
Copy link
Contributor

jcaip commented Mar 19, 2025

cc @drisspg any thoughts here?

@drisspg
Copy link
Contributor

drisspg commented Mar 19, 2025

not particularly, I dont think pytest has broken that much internally since we have relatively vanilla usage, if someone did a full swap sure seems like BE project for a motivated individual

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants