Skip to content

Commit d4a27a0

Browse files
authored
[CircleCI Windows Failure] Fix the way we join URL pieces to download XLM-R components (#1441)
1 parent a26a8ef commit d4a27a0

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

torchtext/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import os
2-
_TEXT_BUCKET = 'https://download.pytorch.org/models/text'
2+
_TEXT_BUCKET = 'https://download.pytorch.org/models/text/'
33
_CACHE_DIR = os.path.expanduser('~/.torchtext/cache')
44

55
from . import data

torchtext/models/roberta/bundler.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11

2-
import os
32
from dataclasses import dataclass
43
from functools import partial
4+
from urllib.parse import urljoin
55

66
from typing import Optional, Callable
77
from torchtext._download_hooks import load_state_dict_from_url
@@ -100,19 +100,19 @@ def encoderConf(self) -> RobertaEncoderConf:
100100

101101

102102
XLMR_BASE_ENCODER = RobertaModelBundle(
103-
_path=os.path.join(_TEXT_BUCKET, "xlmr.base.encoder.pt"),
103+
_path=urljoin(_TEXT_BUCKET, "xlmr.base.encoder.pt"),
104104
_encoder_conf=RobertaEncoderConf(vocab_size=250002),
105105
transform=partial(get_xlmr_transform,
106-
vocab_path=os.path.join(_TEXT_BUCKET, "xlmr.vocab.pt"),
107-
spm_model_path=os.path.join(_TEXT_BUCKET, "xlmr.sentencepiece.bpe.model"),
106+
vocab_path=urljoin(_TEXT_BUCKET, "xlmr.vocab.pt"),
107+
spm_model_path=urljoin(_TEXT_BUCKET, "xlmr.sentencepiece.bpe.model"),
108108
)
109109
)
110110

111111
XLMR_LARGE_ENCODER = RobertaModelBundle(
112-
_path=os.path.join(_TEXT_BUCKET, "xlmr.large.encoder.pt"),
112+
_path=urljoin(_TEXT_BUCKET, "xlmr.large.encoder.pt"),
113113
_encoder_conf=RobertaEncoderConf(vocab_size=250002, embedding_dim=1024, ffn_dimension=4096, num_attention_heads=16, num_encoder_layers=24),
114114
transform=partial(get_xlmr_transform,
115-
vocab_path=os.path.join(_TEXT_BUCKET, "xlmr.vocab.pt"),
116-
spm_model_path=os.path.join(_TEXT_BUCKET, "xlmr.sentencepiece.bpe.model"),
115+
vocab_path=urljoin(_TEXT_BUCKET, "xlmr.vocab.pt"),
116+
spm_model_path=urljoin(_TEXT_BUCKET, "xlmr.sentencepiece.bpe.model"),
117117
)
118118
)

0 commit comments

Comments
 (0)