Migrate fsdp1 -> fsdp2 in Tensor Parallelism Tutorial #3464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3464
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 55493b2 with merge base d5cd489 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
svekars
approved these changes
Jul 15, 2025
Contributor
Author
|
cc @tianyu-l |
tianyu-l
approved these changes
Jul 16, 2025
Contributor
tianyu-l
left a comment
tianyu-l
left a comment
There was a problem hiding this comment.
thanks for working on this!
svekars
pushed a commit
that referenced
this pull request
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Pytorch Tutorial Audit - Tensor Parallelism Tutorial
Description
Migrate from FSDP1 to FSDP2 in Tensor Parallelism tutorial
Related changes in examples repo: pytorch/examples#1372
Checklist