Skip to content

Commit 6ec0594

Browse files
committed
Merge pull request #117 from qiniu/develop
6.0.6 patch
2 parents 10ed8d0 + 04b4d13 commit 6ec0594

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

conf/conf.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ var SECRET_KEY string
2121

2222
var version = "6.0.6"
2323

24-
var userPattern = regexp.MustCompile("^[:word:]*$")
24+
var userPattern = regexp.MustCompile("^[a-zA-Z0-9_.-]*$")
2525

2626
// user should be [A-Za-z0-9]*
2727
func SetUser(user string) error {

conf/conf_test.go

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,22 @@ import (
88
func TestUA(t *testing.T) {
99
err := SetUser("")
1010
if err != nil {
11-
t.Fatal(err)
11+
t.Fatal("expect no error")
1212
}
1313
err = SetUser("错误的UA")
1414
if err == nil {
1515
t.Fatal("expect an invalid ua format")
1616
}
17+
err = SetUser("Test0-_.")
18+
if err != nil {
19+
t.Fatal("expect no error")
20+
}
1721
}
1822

1923
func TestFormat(t *testing.T) {
20-
v := formatUserAgent("test")
21-
if !strings.Contains(v, "test") {
24+
str := "tesT0.-_"
25+
v := formatUserAgent(str)
26+
if !strings.Contains(v, str) {
2227
t.Fatal("should include user")
2328
}
2429
if !strings.HasPrefix(v, "QiniuGo/"+version) {

0 commit comments

Comments
 (0)