Skip to content

Commit 2d44233

Browse files
authored
Merge pull request #6 from davidanthoff/fix-skipstartrows-etc
Fix bug related to skipstartrows etc.
2 parents bd0089e + 7d63166 commit 2d44233

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

NEWS.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
# ExcelFiles.jl v0.3.1
2+
* Fix bug related to skipstartrows etc.
3+
14
# ExcelFiles.jl v0.3.0
25
* Incorporate all table functionality from ExcelReaders.jl.
36
* Drop dependency on DataTables.jl and DataFrames.jl.

src/ExcelFiles.jl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,10 @@ function IteratorInterfaceExtensions.getiterator(file::ExcelFile)
9393
sheet = excelfile.workbook[:sheet_by_name](file.range)
9494
startrow, startcol, endrow, endcol = ExcelReaders.convert_args_to_row_col(sheet; file.keywords...)
9595

96-
_readxl(excelfile, file.range, startrow, startcol, endrow, endcol; file.keywords...)
96+
keywords2 = copy(file.keywords)
97+
keywords2 = filter(i->!(i[1] in (:skipstartrows, :skipstartcols, :nrows, :ncols)), file.keywords)
98+
99+
_readxl(excelfile, file.range, startrow, startcol, endrow, endcol; keywords2...)
97100
end
98101

99102
return create_tableiterator(column_data, col_names)

0 commit comments

Comments
 (0)