Skip to content

Use tidy principles for daemons() 'dispatcher' argument #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shikokuchuo opened this issue Sep 17, 2024 · 0 comments · Fixed by #158
Closed

Use tidy principles for daemons() 'dispatcher' argument #157

shikokuchuo opened this issue Sep 17, 2024 · 0 comments · Fixed by #158
Assignees
@shikokuchuo

Comments

@shikokuchuo
Copy link
Member

As suggested by @hadley in #142 (comment).

Now with threaded dispatcher, this argument is no longer boolean. However, it is easy to continue using the existing name and special case the existing TRUE/FALSE so they continue to work as before.

Replacing with dispatcher = c("process", "thread", "none") has the following additional advantages:

  • encourages use of dispatcher = "thread" as the NA option is non-obvious
  • having dispatcher = "none" as one of 3 options makes it seem subtly less undesirable than dispatcher = FALSE
  • allows the eventual transition to "thread" as the default, with downstream packages able to lock in dispatcher = "process"
@shikokuchuo shikokuchuo changed the title Use tidy principles for daemons() 'dispatcher' argumnet Use tidy principles for daemons() 'dispatcher' argument Sep 17, 2024
@shikokuchuo shikokuchuo self-assigned this Sep 17, 2024
@shikokuchuo shikokuchuo mentioned this issue Sep 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shikokuchuo shikokuchuo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use dispatcher = c('process', 'thread', 'none') r-lib/mirai
1 participant
@shikokuchuo