Skip to content

Something wrong with the 2.1.0 release #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
n-rodriguez opened this issue Aug 17, 2020 · 2 comments
Closed

Something wrong with the 2.1.0 release #622

n-rodriguez opened this issue Aug 17, 2020 · 2 comments

Comments

@n-rodriguez
Copy link

n-rodriguez commented Aug 17, 2020

Hi there!

I think there is something wrong with the 2.1.0 release : I've manually downloaded the zip file from Rubygems (https://rubygems.org/downloads/spring-2.1.0.gem) and looked into lib/spring/configuration.rb and found this :

require "spring/errors"

module Spring
  class << self
    attr_accessor :application_root, :quiet

    def gemfile
      ENV['BUNDLE_GEMFILE'] || "Gemfile"
    end
...

instead of https://github.com/rails/spring/pull/588/files

From the Changelog this patch should be in 2.1.0 : https://github.com/rails/spring/blob/master/CHANGELOG.md#210

@n-rodriguez
Copy link
Author

n-rodriguez commented Aug 17, 2020

The patch was added after 2.1.0 release : v2.1.0...master

The changelog will need update.

@n-rodriguez
Copy link
Author

@guilleiguaran can you please update the CHANGELOG? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant