Skip to content

"spring binstub --all" contradicts what Rails 6.1.0 "rails new" recommends #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattbrictson opened this issue Dec 22, 2020 · 2 comments

Comments

@mattbrictson
Copy link
Contributor

mattbrictson commented Dec 22, 2020

As of Rails 6.1.0, rails new generates its own "spring-ified" binstubs:

bin/rake
bin/rails
bin/spring

These binstubs are different than the ones that spring itself recommends. If you run spring binstub --all you will get a different set of files.

Prior to Rails 6.1.0, rails new used to call spring binstub to generate the bin/spring binstub. But as of Rails commit 72d10e21, spring binstub has been removed and Rails has slightly diverged from the Spring recommendations. It now uses these binstub templates: bin/spring, bin/rake, bin/rails.

Should this repository be updated to match the official Rails recommendations?

Or alternatively, should the README be updated to make it clear that you should not run spring binstub --all for Rails 6.1 projects?

@deivid-rodriguez
Copy link
Contributor

I noticed this today too.

I'd say the new templates should be ported to this repository. Spring only makes sense when used with Rails so these should match.

@mattbrictson
Copy link
Contributor Author

Rails doesn't generate Spring binstubs anymore (as of Rails 7), so I think this issue is no longer relevant. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants