-
Notifications
You must be signed in to change notification settings - Fork 340
Bundler.with_original_env
vs Bundler.with_unbundled_env
#669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@rafaelfranca I couldn't find the reason in the PR for the change. Can you help clarify? Thank you! |
Same here. Downgrading to 3.1.1 fix the issue. |
Fixed in 7fcb742 |
Is there any chance we could get this change released as a patch-level release on 4.0? We've been unable to upgrade to spring 4.0 because our gems locations are non standard. Much ❤️ - thanks for the gem. It saves us ridiculous amounts of time when devving on some of our larger systems |
Just a smol bump to ping @rafaelfranca if it's possible to release a |
+1 with the 4.0.1 release |
I believe this change has broken things for us for environments that use bundler environment variables:
https://github.com/rails/spring/pull/661/files#diff-badda36a241454b100b8aba52c978271cff008a57451d78e600fa62c3d65d8d9L96-R96
For example, if you set the
BUNDLE_PATH=some/path/to/bundle
environment variable, it's not picked up because of theBundler.with_unbundled_env
change.The text was updated successfully, but these errors were encountered: