Skip to content

Bundler.with_original_env vs Bundler.with_unbundled_env #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ngan opened this issue Jan 6, 2022 · 6 comments
Closed

Bundler.with_original_env vs Bundler.with_unbundled_env #669

ngan opened this issue Jan 6, 2022 · 6 comments

Comments

@ngan
Copy link

ngan commented Jan 6, 2022

I believe this change has broken things for us for environments that use bundler environment variables:
https://github.com/rails/spring/pull/661/files#diff-badda36a241454b100b8aba52c978271cff008a57451d78e600fa62c3d65d8d9L96-R96

For example, if you set the BUNDLE_PATH=some/path/to/bundle environment variable, it's not picked up because of the Bundler.with_unbundled_env change.

@ngan
Copy link
Author

ngan commented Jan 6, 2022

@rafaelfranca I couldn't find the reason in the PR for the change. Can you help clarify? Thank you!

@ngelx
Copy link

ngelx commented Jan 17, 2022

Same here. Downgrading to 3.1.1 fix the issue.

@rafaelfranca
Copy link
Member

Fixed in 7fcb742

@gee-forr
Copy link

Is there any chance we could get this change released as a patch-level release on 4.0? We've been unable to upgrade to spring 4.0 because our gems locations are non standard.

Much ❤️ - thanks for the gem. It saves us ridiculous amounts of time when devving on some of our larger systems

@gee-forr
Copy link

Just a smol bump to ping @rafaelfranca if it's possible to release a 4.0.1 that includes this fix?

@heberuriegas
Copy link

+1 with the 4.0.1 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants